From 1d354e11c8627062a62faff63a8d942a7b126af3 Mon Sep 17 00:00:00 2001 From: leftibot Date: Sat, 2 May 2026 11:09:09 -0600 Subject: [PATCH] Address review: restore CHAISCRIPT_DEBUG to true/false for stronger typing C++ preserves the true/false keywords in #if directives ([cpp.cond]), so the MSVC Debug guard around CHAISCRIPT_MAX_CALL_DEPTH still works without weakening the macro to integer 1/0. Requested by @lefticus in PR #700 review. Co-Authored-By: Claude Opus 4.7 (1M context) --- include/chaiscript/chaiscript_defines.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/chaiscript/chaiscript_defines.hpp b/include/chaiscript/chaiscript_defines.hpp index 3272245b..f8677ec8 100644 --- a/include/chaiscript/chaiscript_defines.hpp +++ b/include/chaiscript/chaiscript_defines.hpp @@ -70,9 +70,9 @@ static_assert(_MSC_FULL_VER >= 190024210, "Visual C++ 2015 Update 3 or later req #endif #ifdef _DEBUG -#define CHAISCRIPT_DEBUG 1 +#define CHAISCRIPT_DEBUG true #else -#define CHAISCRIPT_DEBUG 0 +#define CHAISCRIPT_DEBUG false #endif // Upper bound on the depth of nested ChaiScript function calls. Hitting it