From 861805d9c32599d919bebd17224c7dee42bc9d51 Mon Sep 17 00:00:00 2001 From: leftibot Date: Sat, 11 Apr 2026 19:41:47 -0600 Subject: [PATCH] Address review: use Ninja generator for all unix CI targets Requested by @lefticus in PR #670 review. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/ci.yml | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 183e1fce..ff0c6778 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,8 +19,11 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install Ninja + run: sudo apt-get install -y ninja-build + - name: Configure - run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DMULTITHREAD_SUPPORT_ENABLED=${{ matrix.multithread }} + run: cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DMULTITHREAD_SUPPORT_ENABLED=${{ matrix.multithread }} - name: Build run: cmake --build build -j @@ -39,8 +42,11 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install Ninja + run: brew install ninja + - name: Configure - run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DMULTITHREAD_SUPPORT_ENABLED=${{ matrix.multithread }} + run: cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DMULTITHREAD_SUPPORT_ENABLED=${{ matrix.multithread }} - name: Build run: cmake --build build -j @@ -58,8 +64,11 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install Ninja + run: sudo apt-get install -y ninja-build + - name: Configure - run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_ADDRESS_SANITIZER=ON -DENABLE_UNDEFINED_SANITIZER=ON + run: cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_ADDRESS_SANITIZER=ON -DENABLE_UNDEFINED_SANITIZER=ON - name: Build run: cmake --build build -j @@ -77,8 +86,11 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install Ninja + run: brew install ninja + - name: Configure - run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_ADDRESS_SANITIZER=ON -DENABLE_UNDEFINED_SANITIZER=ON + run: cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_ADDRESS_SANITIZER=ON -DENABLE_UNDEFINED_SANITIZER=ON - name: Build run: cmake --build build -j @@ -116,8 +128,11 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install Ninja + run: sudo apt-get install -y ninja-build + - name: Configure - run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_THREAD_SANITIZER=ON -DMULTITHREAD_SUPPORT_ENABLED=ON + run: cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_THREAD_SANITIZER=ON -DMULTITHREAD_SUPPORT_ENABLED=ON - name: Build run: cmake --build build -j @@ -135,8 +150,11 @@ jobs: steps: - uses: actions/checkout@v4 + - name: Install Ninja + run: brew install ninja + - name: Configure - run: cmake -B build -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_THREAD_SANITIZER=ON -DMULTITHREAD_SUPPORT_ENABLED=ON + run: cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DENABLE_THREAD_SANITIZER=ON -DMULTITHREAD_SUPPORT_ENABLED=ON - name: Build run: cmake --build build -j