Merge pull request #608 from FellowTraveler/develop

Add C++20 support

CMakeLists.txt

@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.12)
 cmake_policy(SET CMP0054 NEW)
 
-set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 # required since cmake 3.4 at least for libc++
@@ -167,7 +167,7 @@ if(MSVC)
 else()
   add_definitions(-Wall -Wextra -Wconversion -Wshadow -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wcast-qual -Wunused -Woverloaded-virtual -Wno-noexcept-type -Wpedantic -Werror=return-type)
 
-  if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+  if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang")
     add_definitions(-Weverything -Wno-c++98-compat-pedantic  -Wno-c++98-compat -Wno-documentation -Wno-switch-enum -Wno-weak-vtables -Wno-missing-prototypes -Wno-padded -Wno-missing-noreturn -Wno-exit-time-destructors -Wno-documentation-unknown-command -Wno-unused-template -Wno-undef -Wno-double-promotion)
   else()
     add_definitions(-Wnoexcept)

include/chaiscript/language/chaiscript_common.hpp

@@ -26,6 +26,10 @@
 
 namespace chaiscript {
   struct AST_Node;
+  struct AST_Node_Trace;
+  namespace exception {
+    struct eval_error;
+  }
 } // namespace chaiscript
 
 namespace chaiscript {
@@ -166,11 +170,104 @@ namespace chaiscript {
     std::shared_ptr<std::string> filename;
   };
 
+  /// \brief Struct that doubles as both a parser ast_node and an AST node.
+  struct AST_Node {
+  public:
+    const AST_Node_Type identifier;
+    const std::string text;
+    Parse_Location location;
+
+    const std::string &filename() const noexcept { return *location.filename; }
+
+    const File_Position &start() const noexcept { return location.start; }
+
+    const File_Position &end() const noexcept { return location.end; }
+
+    std::string pretty_print() const {
+      std::ostringstream oss;
+
+      oss << text;
+
+      for (auto &elem : get_children()) {
+        oss << elem.get().pretty_print() << ' ';
+      }
+
+      return oss.str();
+    }
+
+    virtual std::vector<std::reference_wrapper<AST_Node>> get_children() const = 0;
+    virtual Boxed_Value eval(const chaiscript::detail::Dispatch_State &t_e) const = 0;
+
+    /// Prints the contents of an AST node, including its children, recursively
+    std::string to_string(const std::string &t_prepend = "") const {
+      std::ostringstream oss;
+
+      oss << t_prepend << "(" << ast_node_type_to_string(this->identifier) << ") " << this->text << " : " << this->location.start.line
+          << ", " << this->location.start.column << '\n';
+
+      for (auto &elem : get_children()) {
+        oss << elem.get().to_string(t_prepend + "  ");
+      }
+      return oss.str();
+    }
+
+    static inline bool get_bool_condition(const Boxed_Value &t_bv, const chaiscript::detail::Dispatch_State &t_ss);
+
+    virtual ~AST_Node() noexcept = default;
+    AST_Node(AST_Node &&) = default;
+    AST_Node &operator=(AST_Node &&) = delete;
+    AST_Node(const AST_Node &) = delete;
+    AST_Node &operator=(const AST_Node &) = delete;
+
+  protected:
+    AST_Node(std::string t_ast_node_text, AST_Node_Type t_id, Parse_Location t_loc)
+        : identifier(t_id)
+        , text(std::move(t_ast_node_text))
+        , location(std::move(t_loc)) {
+    }
+  };
+
   /// \brief Typedef for pointers to AST_Node objects. Used in building of the AST_Node tree
   using AST_NodePtr = std::unique_ptr<AST_Node>;
   using AST_NodePtr_Const = std::unique_ptr<const AST_Node>;
 
-  struct AST_Node_Trace;
+  struct AST_Node_Trace {
+    const AST_Node_Type identifier;
+    const std::string text;
+    Parse_Location location;
+
+    const std::string &filename() const noexcept { return *location.filename; }
+
+    const File_Position &start() const noexcept { return location.start; }
+
+    const File_Position &end() const noexcept { return location.end; }
+
+    std::string pretty_print() const {
+      std::ostringstream oss;
+
+      oss << text;
+
+      for (const auto &elem : children) {
+        oss << elem.pretty_print() << ' ';
+      }
+
+      return oss.str();
+    }
+
+    std::vector<AST_Node_Trace> get_children(const AST_Node &node) {
+      const auto node_children = node.get_children();
+      return std::vector<AST_Node_Trace>(node_children.begin(), node_children.end());
+    }
+
+    AST_Node_Trace(const AST_Node &node)
+        : identifier(node.identifier)
+        , text(node.text)
+        , location(node.location)
+        , children(get_children(node)) {
+    }
+
+    std::vector<AST_Node_Trace> children;
+  };
 
   /// \brief Classes which may be thrown during error cases when ChaiScript is executing.
   namespace exception {
@@ -495,48 +592,8 @@ namespace chaiscript {
 
   } // namespace exception
 
-  /// \brief Struct that doubles as both a parser ast_node and an AST node.
-  struct AST_Node {
-  public:
-    const AST_Node_Type identifier;
-    const std::string text;
-    Parse_Location location;
-
-    const std::string &filename() const noexcept { return *location.filename; }
-
-    const File_Position &start() const noexcept { return location.start; }
-
-    const File_Position &end() const noexcept { return location.end; }
-
-    std::string pretty_print() const {
-      std::ostringstream oss;
-
-      oss << text;
-
-      for (auto &elem : get_children()) {
-        oss << elem.get().pretty_print() << ' ';
-      }
-
-      return oss.str();
-    }
-
-    virtual std::vector<std::reference_wrapper<AST_Node>> get_children() const = 0;
-    virtual Boxed_Value eval(const chaiscript::detail::Dispatch_State &t_e) const = 0;
-
-    /// Prints the contents of an AST node, including its children, recursively
-    std::string to_string(const std::string &t_prepend = "") const {
-      std::ostringstream oss;
-
-      oss << t_prepend << "(" << ast_node_type_to_string(this->identifier) << ") " << this->text << " : " << this->location.start.line
-          << ", " << this->location.start.column << '\n';
-
-      for (auto &elem : get_children()) {
-        oss << elem.get().to_string(t_prepend + "  ");
-      }
-      return oss.str();
-    }
-
-    static bool get_bool_condition(const Boxed_Value &t_bv, const chaiscript::detail::Dispatch_State &t_ss) {
+  //static
+  bool AST_Node::get_bool_condition(const Boxed_Value &t_bv, const chaiscript::detail::Dispatch_State &t_ss) {
       try {
         return t_ss->boxed_cast<bool>(t_bv);
       } catch (const exception::bad_boxed_cast &) {
@@ -544,58 +601,6 @@ namespace chaiscript {
       }
   }
 
-    virtual ~AST_Node() noexcept = default;
-    AST_Node(AST_Node &&) = default;
-    AST_Node &operator=(AST_Node &&) = delete;
-    AST_Node(const AST_Node &) = delete;
-    AST_Node &operator=(const AST_Node &) = delete;
-
-  protected:
-    AST_Node(std::string t_ast_node_text, AST_Node_Type t_id, Parse_Location t_loc)
-        : identifier(t_id)
-        , text(std::move(t_ast_node_text))
-        , location(std::move(t_loc)) {
-    }
-  };
-
-  struct AST_Node_Trace {
-    const AST_Node_Type identifier;
-    const std::string text;
-    Parse_Location location;
-
-    const std::string &filename() const noexcept { return *location.filename; }
-
-    const File_Position &start() const noexcept { return location.start; }
-
-    const File_Position &end() const noexcept { return location.end; }
-
-    std::string pretty_print() const {
-      std::ostringstream oss;
-
-      oss << text;
-
-      for (const auto &elem : children) {
-        oss << elem.pretty_print() << ' ';
-      }
-
-      return oss.str();
-    }
-
-    std::vector<AST_Node_Trace> get_children(const AST_Node &node) {
-      const auto node_children = node.get_children();
-      return std::vector<AST_Node_Trace>(node_children.begin(), node_children.end());
-    }
-
-    AST_Node_Trace(const AST_Node &node)
-        : identifier(node.identifier)
-        , text(node.text)
-        , location(node.location)
-        , children(get_children(node)) {
-    }
-
-    std::vector<AST_Node_Trace> children;
-  };
-
   namespace parser {
     class ChaiScript_Parser_Base {
     public:

unittests/compiled_tests.cpp

@@ -1032,7 +1032,7 @@ TEST_CASE("Use unique_ptr") {
   chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());
 
   chai.add(chaiscript::fun([](int &i) { ++i; }), "inci");
-  chai.add(chaiscript::fun([](int i) { ++i; }), "copyi");
+  chai.add(chaiscript::fun([]([[maybe_unused]] int i) { ++i; }), "copyi");
   chai.add(chaiscript::fun([](int *i) { ++(*i); }), "derefi");
   chai.add(chaiscript::fun([](const std::unique_ptr<int> &i) { ++(*i); }), "constrefuniqptri");
   chai.add(chaiscript::fun([](std::unique_ptr<int> &i) { ++(*i); }), "refuniqptri");

unittests/static_chaiscript.cpp

@@ -6,8 +6,14 @@
 /// ChaiScript as a static is unsupported with thread support enabled
 ///
 
+#if defined(__clang__)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wexit-time-destructors"
+#pragma clang diagnostic ignored "-Wglobal-constructors"
+#endif
+
 #include <chaiscript/chaiscript.hpp>
 
-static chaiscript::ChaiScript chai;
+static chaiscript::ChaiScript chai{};
 
 int main() {}