From c7fcc9f7d9e4ebd11a3d193e490523665c3890b2 Mon Sep 17 00:00:00 2001 From: Rob Loach Date: Thu, 7 Jan 2021 13:15:47 -0500 Subject: [PATCH] Fix stack_vector.pop_back() pre-decrementing Fixes #547, found by @balint-luko. --- include/chaiscript/utility/stack_vector.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/chaiscript/utility/stack_vector.hpp b/include/chaiscript/utility/stack_vector.hpp index 706d276a..c72bfe6c 100644 --- a/include/chaiscript/utility/stack_vector.hpp +++ b/include/chaiscript/utility/stack_vector.hpp @@ -43,7 +43,7 @@ struct Stack_Vector }; void pop_back() noexcept(std::is_nothrow_destructible_v) { - (*this)[m_size--].~T(); + (*this)[--m_size].~T(); } ~Stack_Vector() noexcept(std::is_nothrow_destructible_v)