From 66a66f15ecf02ab14e71ee3e314fb3ab185ffeb3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=9C=A8=E5=A4=B4=E4=BA=91?= <372449116@qq.com> Date: Mon, 15 Dec 2025 11:42:57 +0000 Subject: [PATCH] fix(log): fix Windows platform compilation errors - src/libipc/platform/win/get_sa.h: * Fix malformed log.error() calls on lines 19 and 23 * Remove extra comma and parenthesis: GetLastError(, -> GetLastError() * Fix closing parenthesis and bracket placement * Line 19: GetLastError(, "]"))) -> GetLastError()), "]" * Line 23: GetLastError(, "]"))) -> GetLastError()), "]" - src/libipc/platform/win/mutex.h: * Add missing LIBIPC_LOG() to try_lock() function at line 84 * The function uses log.error() at line 95 and needs logger initialization These fixes resolve Windows compilation errors related to malformed log calls and missing LIBIPC_LOG() macro. --- src/libipc/platform/win/get_sa.h | 4 ++-- src/libipc/platform/win/mutex.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libipc/platform/win/get_sa.h b/src/libipc/platform/win/get_sa.h index 4dc3a2b..b512541 100644 --- a/src/libipc/platform/win/get_sa.h +++ b/src/libipc/platform/win/get_sa.h @@ -16,11 +16,11 @@ inline LPSECURITY_ATTRIBUTES get_sa() { initiator() { if (!::InitializeSecurityDescriptor(&sd_, SECURITY_DESCRIPTOR_REVISION)) { - log.error("fail InitializeSecurityDescriptor[", static_cast(::GetLastError(, "]"))); + log.error("fail InitializeSecurityDescriptor[", static_cast(::GetLastError()), "]"); return; } if (!::SetSecurityDescriptorDacl(&sd_, TRUE, NULL, FALSE)) { - log.error("fail SetSecurityDescriptorDacl[", static_cast(::GetLastError(, "]"))); + log.error("fail SetSecurityDescriptorDacl[", static_cast(::GetLastError()), "]"); return; } sa_.nLength = sizeof(SECURITY_ATTRIBUTES); diff --git a/src/libipc/platform/win/mutex.h b/src/libipc/platform/win/mutex.h index 1989d95..ae0e243 100644 --- a/src/libipc/platform/win/mutex.h +++ b/src/libipc/platform/win/mutex.h @@ -82,6 +82,7 @@ public: } bool try_lock() noexcept(false) { + LIBIPC_LOG(); DWORD ret = ::WaitForSingleObject(h_, 0); switch (ret) { case WAIT_OBJECT_0: