From 774a3c9af7f6097b2c3c34e5cc8290688173896f Mon Sep 17 00:00:00 2001
From: mutouyun <orz@orzz.org>
Date: Sat, 2 Sep 2023 10:52:37 +0800
Subject: [PATCH] fixed a stupid bug in benchmark

---
 benchmark/benchmark_ipc.cpp | 51 +++++++++++++++++++++++++++++--------
 src/libipc/event.cpp        |  2 ++
 test/ipc/test_ipc_event.cpp |  2 ++
 3 files changed, 45 insertions(+), 10 deletions(-)

diff --git a/benchmark/benchmark_ipc.cpp b/benchmark/benchmark_ipc.cpp
index 8f31013..0c2b649 100644
--- a/benchmark/benchmark_ipc.cpp
+++ b/benchmark/benchmark_ipc.cpp
@@ -9,6 +9,7 @@
 #include <sys/types.h>
 #include <sys/inotify.h>
 #include <netinet/in.h>
+#include <errno.h>
 
 #include <string.h>
 #include <unistd.h>
@@ -72,14 +73,27 @@ struct mqueue_reader {
       auto shm = ipc::shared_memory("shm-mqueue_reader", sizeof(flag_t));
       auto flag = shm.as<flag_t>();
       printf("mqueue_reader start.\n");
-      mqd_t wfd = mq_open("/mqueue-wfd", O_RDONLY);
-      mqd_t rfd = mq_open("/mqueue-rfd", O_WRONLY);
+      mq_unlink("/mqueue-wfd");
+      mq_unlink("/mqueue-rfd");
+      struct mq_attr attr = {0, 10, 1, 0};
+      mqd_t wfd = mq_open("/mqueue-wfd", O_CREAT | O_RDONLY, 0666, &attr);
+      mqd_t rfd = mq_open("/mqueue-rfd", O_CREAT | O_WRONLY, 0666, &attr);
+      if (wfd < 0 || rfd < 0) {
+        printf("mq_open error. errno = %d\n", errno);
+        return;
+      }
       while (!flag->load(std::memory_order_relaxed)) {
         char n {};
         // read
-        mq_receive(wfd, &n, sizeof(n), nullptr);
+        if (mq_receive(wfd, &n, sizeof(n), nullptr) < 0) {
+          printf("mq_receive error. errno = %d\n", errno);
+          return;
+        }
         // write
-        mq_send(rfd, &n, sizeof(n), 0);
+        if (mq_send(rfd, &n, sizeof(n), 0) < 0) {
+          printf("mq_send error. errno = %d\n", errno);
+          return;
+        }
       }
       printf("mqueue_reader exit.\n");
       mq_close(wfd);
@@ -91,9 +105,16 @@ struct mqueue_reader {
     auto shm = ipc::shared_memory("shm-mqueue_reader", sizeof(flag_t));
     shm.as<flag_t>()->store(true, std::memory_order_seq_cst);
     {
-      mqd_t wfd = mq_open("/mqueue-wfd", O_WRONLY);
+      mqd_t wfd = mq_open("/mqueue-wfd", O_EXCL | O_WRONLY, 0666, NULL);
+      if (wfd < 0) {
+        printf("mq_open error. errno = %d\n", errno);
+        return;
+      }
       char n {};
-      mq_send(wfd, &n, sizeof(n), 0);
+      if (mq_send(wfd, &n, sizeof(n), 0) < 0) {
+        printf("mq_send error. errno = %d\n", errno);
+        return;
+      }
       mq_close(wfd);
     }
     test::join_subproc(pid_);
@@ -314,14 +335,24 @@ void ipc_eventfd_rtt(benchmark::State &state) {
 }
 
 void ipc_mqueue_rtt(benchmark::State &state) {
-  mqd_t wfd = mq_open("/mqueue-wfd", O_WRONLY);
-  mqd_t rfd = mq_open("/mqueue-rfd", O_RDONLY);
+  mqd_t wfd = mq_open("/mqueue-wfd", O_EXCL | O_WRONLY, 0666, NULL);
+  mqd_t rfd = mq_open("/mqueue-rfd", O_EXCL | O_RDONLY, 0666, NULL);
+  if (wfd < 0 || rfd < 0) {
+    printf("mq_open error. errno = %d\n", errno);
+    return;
+  }
   for (auto _ : state) {
     char n {};
     // write
-    mq_send(wfd, &n, sizeof(n), 0);
+    if (mq_send(wfd, &n, sizeof(n), 0) < 0) {
+      printf("mq_send error. errno = %d\n", errno);
+      return;
+    }
     // read
-    mq_receive(rfd, &n, sizeof(n), nullptr);
+    if (mq_receive(rfd, &n, sizeof(n), nullptr) < 0) {
+      printf("mq_receive error. errno = %d\n", errno);
+      return;
+    }
   }
   mq_close(wfd);
   mq_close(rfd);
diff --git a/src/libipc/event.cpp b/src/libipc/event.cpp
index 81fb9cb..5fa762d 100644
--- a/src/libipc/event.cpp
+++ b/src/libipc/event.cpp
@@ -7,6 +7,7 @@
 #else
 #endif
 
+#if !defined(LIBIMP_OS_LINUX)
 LIBIPC_NAMESPACE_BEG_
 
 /// \brief C style event access interface implementation.
@@ -23,3 +24,4 @@ std::string evt_name(evt_t evt) noexcept {
 /// \brief The event object.
 
 LIBIPC_NAMESPACE_END_
+#endif
diff --git a/test/ipc/test_ipc_event.cpp b/test/ipc/test_ipc_event.cpp
index a0332b1..c4398e1 100644
--- a/test/ipc/test_ipc_event.cpp
+++ b/test/ipc/test_ipc_event.cpp
@@ -5,6 +5,7 @@
 
 #include <libipc/event.h>
 
+#if !defined(LIBIMP_OS_LINUX)
 TEST(event, open_close) {
   auto evt = ipc::evt_open("test");
   ASSERT_TRUE(evt);
@@ -97,3 +98,4 @@ TEST(event, unicast_multi) {
   ASSERT_TRUE(ipc::evt_close(*evt3));
   ASSERT_EQ(success, 1);
 }
+#endif