coffee/etl
1
0
Fork 0
mirror of https://github.com/ETLCPP/etl.git synced 2026-11-09 14:49:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

harmonize copy ctor and asignment op for etl::delegate (#465)

Browse Source 
etl::delegate has a user-written copy constructor and a defaulted assignment
operator. The copy constructor does the same as a defaulted copy constructor,
therefore there is no need to add a user-written copy constructor.

The combination of user-written copy constructor and defaulted assignment
operator causes a warning in Coverity, a static code analyzer:

copy_without_assign: Class etl::delegate<void ()> has a user-written copy constructor etl::delegate<void ()>::delegate(etl::delegate<void ()> const &) but no corresponding user-written assignment operator.

This commit replaces the user-written copy constructor with a defaulted copy
constructor, which does the same.
This commit is contained in:
Steffen Zimmermann 2021-11-15 12:02:02 +01:00 committed by GitHub
parent c70db16a20
commit 32e8134ca4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/etl/delegate.h
View File

@ -111,10 +111,7 @@ namespace etl
//*************************************************************************
// Copy constructor.
//*************************************************************************
ETL_CONSTEXPR14 delegate(const delegate& other)
: invocation(other.invocation)
{
}
ETL_CONSTEXPR14 delegate(const delegate& other) = default;
//*************************************************************************
// Construct from lambda or functor.