From 5e78b48b6cda8429b493e5b43b18a982307c5ecb Mon Sep 17 00:00:00 2001 From: John Wellbelove Date: Sat, 20 Jan 2024 18:35:20 +0000 Subject: [PATCH] #815 etl::remove_if calls predicate twice for first iterator, where predicate returns true. --- include/etl/algorithm.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/etl/algorithm.h b/include/etl/algorithm.h index dd01415a..a6c96162 100644 --- a/include/etl/algorithm.h +++ b/include/etl/algorithm.h @@ -2021,9 +2021,7 @@ namespace etl template ETL_CONSTEXPR14 TIterator remove(TIterator first, TIterator last, const T& value) - { - first = etl::find(first, last, value); - + { if (first != last) { TIterator itr = first; @@ -2051,8 +2049,6 @@ namespace etl ETL_CONSTEXPR14 TIterator remove_if(TIterator first, TIterator last, TUnaryPredicate predicate) { - first = etl::find_if(first, last, predicate); - if (first != last) { TIterator itr = first;