Updated with coderabbit suggestions

This commit is contained in:
John Wellbelove 2026-03-01 12:14:10 +00:00
parent 398ef49124
commit 6d8bba986c
4 changed files with 7 additions and 15 deletions

View File

@ -350,7 +350,7 @@ namespace
CHECK(isEqual); CHECK(isEqual);
CHECK_TRUE(std::is_sorted(otherData.begin(), otherData.end(), data.value_comp())); CHECK_TRUE(std::is_sorted(otherData.begin(), otherData.end(), otherData.value_comp()));
} }
//************************************************************************* //*************************************************************************
@ -1705,13 +1705,8 @@ namespace
const std::vector<element> actual(data.begin(), data.end()); const std::vector<element> actual(data.begin(), data.end());
CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.value_comp())); CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.value_comp()));
CHECK_EQUAL(expected.size(), actual.size());
auto compare = [](const etl::map<int, int, 8>::value_type& lhs, const etl::map<int, int, 8>::value_type& rhs) CHECK_TRUE(actual == expected);
{
return (lhs.first == rhs.first) && (lhs.second == rhs.second);
};
CHECK_TRUE((std::equal(data.begin(), data.end(), expected.begin(), compare)));
} while (std::next_permutation(permutation.begin(), permutation.end())); } while (std::next_permutation(permutation.begin(), permutation.end()));
} }

View File

@ -1742,13 +1742,8 @@ namespace
const std::vector<element> actual(data.begin(), data.end()); const std::vector<element> actual(data.begin(), data.end());
CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.value_comp())); CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.value_comp()));
CHECK_EQUAL(expected.size(), actual.size());
auto compare = [](const etl::multimap<int, int, 8>::value_type& lhs, const etl::multimap<int, int, 8>::value_type& rhs) CHECK_TRUE(actual == expected);
{
return (lhs.first == rhs.first) && (lhs.second == rhs.second);
};
CHECK_TRUE((std::equal(data.begin(), data.end(), expected.begin(), compare)));
} while (std::next_permutation(permutation.begin(), permutation.end())); } while (std::next_permutation(permutation.begin(), permutation.end()));
} }

View File

@ -1665,6 +1665,7 @@ namespace
data.erase(it); data.erase(it);
CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.key_comp())); CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.key_comp()));
CHECK_EQUAL(expected.size(), data.size());
CHECK_TRUE((std::equal(data.begin(), data.end(), expected.begin()))); CHECK_TRUE((std::equal(data.begin(), data.end(), expected.begin())));
} while (std::next_permutation(permutation.begin(), permutation.end())); } while (std::next_permutation(permutation.begin(), permutation.end()));

View File

@ -1502,6 +1502,7 @@ namespace
data.erase(it); data.erase(it);
CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.key_comp())); CHECK_TRUE(std::is_sorted(data.begin(), data.end(), data.key_comp()));
CHECK_EQUAL(expected.size(), data.size());
CHECK_TRUE((std::equal(data.begin(), data.end(), expected.begin()))); CHECK_TRUE((std::equal(data.begin(), data.end(), expected.begin())));
} while (std::next_permutation(permutation.begin(), permutation.end())); } while (std::next_permutation(permutation.begin(), permutation.end()));