From 790b29a9f9d836a795b0543b88e57b9c576506a3 Mon Sep 17 00:00:00 2001
From: John Wellbelove <smartgit@wellbelove.co.uk>
Date: Sat, 4 Jun 2016 21:11:12 +0100
Subject: [PATCH] Fixed bug in binary > operator.

---
 src/array.h         | 17 +++--------------
 src/ideque.h        |  6 +-----
 src/iforward_list.h |  6 +-----
 src/ilist.h         |  6 +-----
 src/imap.h          |  6 +-----
 src/imultimap.h     |  6 +-----
 src/imultiset.h     |  6 +-----
 src/iset.h          |  6 +-----
 src/ivector.h       |  2 +-
 9 files changed, 11 insertions(+), 50 deletions(-)

diff --git a/src/array.h b/src/array.h
index ac0a80b6..1574fb93 100644
--- a/src/array.h
+++ b/src/array.h
@@ -416,11 +416,7 @@ namespace etl
   template <typename T, std::size_t SIZE>
   bool operator <=(const etl::array<T, SIZE>& lhs, const etl::array<T, SIZE>& rhs)
   {
-    return !std::lexicographical_compare(lhs.cbegin(),
-                                         lhs.cend(), 
-                                         rhs.cbegin(),
-                                         rhs.cend(),
-                                         std::greater<T>());
+    return !operator >(lhs, rhs);
   }
 
   //*************************************************************************
@@ -432,11 +428,7 @@ namespace etl
   //*************************************************************************
   bool operator >(const etl::array<T, SIZE>& lhs, const etl::array<T, SIZE>& rhs)
   {
-    return std::lexicographical_compare(lhs.cbegin(),
-                                        lhs.cend(), 
-                                        rhs.cbegin(), 
-                                        rhs.cend(),
-                                        std::greater<T>());
+    return operator <(rhs, lhs);
   }
 
   //*************************************************************************
@@ -448,10 +440,7 @@ namespace etl
   template <typename T, std::size_t SIZE>
   bool operator >=(const etl::array<T, SIZE>& lhs, const etl::array<T, SIZE>& rhs)
   {
-    return !std::lexicographical_compare(lhs.cbegin(), 
-                                         lhs.cend(), 
-                                         rhs.cbegin(),
-                                         rhs.cend());
+    return !operator <(lhs, rhs);
   }
 
   //*************************************************************************
diff --git a/src/ideque.h b/src/ideque.h
index a700904d..62911c42 100644
--- a/src/ideque.h
+++ b/src/ideque.h
@@ -1444,11 +1444,7 @@ bool operator <=(const etl::ideque<T>& lhs, const etl::ideque<T>& rhs)
 template <typename T>
 bool operator >(const etl::ideque<T>& lhs, const etl::ideque<T>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<T>());
+  return operator <(rhs, lhs);
 }
 
 //***************************************************************************
diff --git a/src/iforward_list.h b/src/iforward_list.h
index 98ecdc20..7fa310c9 100644
--- a/src/iforward_list.h
+++ b/src/iforward_list.h
@@ -1015,11 +1015,7 @@ bool operator <(const etl::iforward_list<T>& lhs, const etl::iforward_list<T>& r
 template <typename T>
 bool operator >(const etl::iforward_list<T>& lhs, const etl::iforward_list<T>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<T>());
+  return operator <(rhs, lhs);
 }
 
 //*************************************************************************
diff --git a/src/ilist.h b/src/ilist.h
index b969f71d..7a21e381 100644
--- a/src/ilist.h
+++ b/src/ilist.h
@@ -1168,11 +1168,7 @@ bool operator <(const etl::ilist<T>& lhs, const etl::ilist<T>& rhs)
 template <typename T>
 bool operator >(const etl::ilist<T>& lhs, const etl::ilist<T>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<T>());
+  return operator <(rhs, lhs);
 }
 
 //*************************************************************************
diff --git a/src/imap.h b/src/imap.h
index cd6dd2e9..0d0fad68 100644
--- a/src/imap.h
+++ b/src/imap.h
@@ -1652,11 +1652,7 @@ bool operator <(const etl::imap<TKey, TMapped, TKeyCompare>& lhs, const etl::ima
 template <typename TKey, typename TMapped, typename TKeyCompare>
 bool operator >(const etl::imap<TKey, TMapped, TKeyCompare>& lhs, const etl::imap<TKey, TMapped, TKeyCompare>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<TMapped>());
+  return operator <(rhs, lhs);
 }
 
 //*************************************************************************
diff --git a/src/imultimap.h b/src/imultimap.h
index 628e1239..a1505827 100644
--- a/src/imultimap.h
+++ b/src/imultimap.h
@@ -1385,11 +1385,7 @@ bool operator <(const etl::imultimap<TKey, TMapped, TKeyCompare>& lhs, const etl
 template <typename TKey, typename TMapped, typename TKeyCompare>
 bool operator >(const etl::imultimap<TKey, TMapped, TKeyCompare>& lhs, const etl::imultimap<TKey, TMapped, TKeyCompare>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<TMapped>());
+  return operator <(rhs, lhs);
 }
 
 //*************************************************************************
diff --git a/src/imultiset.h b/src/imultiset.h
index f25d4808..5a05a897 100644
--- a/src/imultiset.h
+++ b/src/imultiset.h
@@ -1366,11 +1366,7 @@ bool operator <(const etl::imultiset<T, TCompare>& lhs, const etl::imultiset<T,
 template <typename T, typename TCompare>
 bool operator >(const etl::imultiset<T, TCompare>& lhs, const etl::imultiset<T, TCompare>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<T>());
+  return operator <(rhs, lhs);
 }
 
 //*************************************************************************
diff --git a/src/iset.h b/src/iset.h
index 17b989d6..21f65924 100644
--- a/src/iset.h
+++ b/src/iset.h
@@ -1583,11 +1583,7 @@ bool operator <(const etl::iset<T, TCompare>& lhs, const etl::iset<T, TCompare>&
 template <typename T, typename TCompare>
 bool operator >(const etl::iset<T, TCompare>& lhs, const etl::iset<T, TCompare>& rhs)
 {
-  return std::lexicographical_compare(lhs.begin(),
-                                      lhs.end(),
-                                      rhs.begin(),
-                                      rhs.end(),
-                                      std::greater<T>());
+  return operator <(rhs, lhs);
 }
 
 //*************************************************************************
diff --git a/src/ivector.h b/src/ivector.h
index 39659469..541ed3f8 100644
--- a/src/ivector.h
+++ b/src/ivector.h
@@ -731,7 +731,7 @@ namespace etl
   template <typename T>
   bool operator >(const etl::ivector<T>& lhs, const etl::ivector<T>& rhs)
   {
-    return std::lexicographical_compare(lhs.begin(), lhs.end(), rhs.begin(), rhs.end(), std::greater<T>());
+    return operator <(rhs, lhs);
   }
 
   //***************************************************************************