etl/test/test_flat_multiset.cpp
rleigh-electradx 70d64496e6
Fix make_array and make_deque rejecting const-qualified lvalues of the element type (#1526)
* Fixed make_array rejecting const-qualified lvalues of the element type

make_array forwarded each argument as T (the element type) rather than
as its own deduced type. etl::forward<T> accepts only a non-const T& or
a T&&, and a T&& cannot bind to a reference-related const lvalue, so
any call passing a const-qualified lvalue of type T failed to compile:

  static const char c = 42;
  etl::make_array<char>(c, c);   // error: would lose const qualifier

Arguments of *other* types slipped through via temporary
materialisation, which is why the existing conversion and move tests
never caught it.

Forward each argument as its own deduced type and convert explicitly
with static_cast<T>. The explicit conversion is required rather than
plain forwarding: function parameters are not constant expressions, so
narrowing initialisers such as make_array<char>(0, 1) - which the old
code accepted and the tests cover - would otherwise be rejected by the
braced initialiser list.

Adds regression tests for const/non-const lvalues of the element type
and for constexpr evaluation. Verified with clang 22 (C++14/17/20) and
GCC 14 (C++11/20); existing conversion and move-only patterns still
compile.

* Fixed make_deque rejecting const-qualified lvalues of the element type

make_deque had the same defect fixed for make_array in the previous
commit: it forwarded each argument as T (the element type) rather than
as its own deduced type. etl::forward<T> accepts only a non-const T& or
a T&&, and a T&& cannot bind to a reference-related const lvalue, so
any call passing a const-qualified lvalue of type T failed to compile:

  static const char c = 42;
  etl::make_deque<char>(c, c);   // error: would lose const qualifier

An audit of all other make_xxx container factories found no further
instances - they forward each argument as its own deduced pack type,
which is the correct idiom.

Forward each argument as its own deduced type and convert explicitly
with static_cast<T>. The explicit conversion keeps narrowing
initialisers such as make_deque<char>(0, 1) - which the old code
accepted and test_make_deque covers - working, which plain forwarding
into the braced initialiser list would reject.

Adds a regression test for const/non-const lvalues of the element type.
No constexpr test, unlike make_array: etl::deque is not a literal type,
so make_deque cannot be evaluated at compile time. Verified with
clang 22 (C++14/17/20); the new test fails to compile before the fix
and passes after, and all 101 deque tests pass.

* Added narrowing-conversion regression tests for make_array and make_deque

Review feedback on the make_deque fix: the const-lvalue regression test
only passes arguments that already have the element type, so nothing
exercises the static_cast<T> conversion that keeps narrowing
initialisers working. If the implementation regressed to plain
forwarding into the braced initialiser list, narrowing calls such as
make_deque<char>(0, 1) would fail to compile.

make_array already covered narrowing from int literals via
test_make_array, but neither container covered conversion from
const-qualified lvalues of a different type (const int narrowed to
char), which combines both dimensions of the fix.

Adds a matching test to each container covering int literals plus
const/non-const int lvalues, all narrowed to char. Verified with
clang 22 (C++17): 102 deque and 53 array tests pass.

* Added const-lvalue regression tests for the remaining make_xxx factories

Review feedback on the make_array/make_deque fixes asked whether the
same defect - rejecting const-qualified lvalue arguments by forwarding
each argument as the element type rather than as its own deduced type -
exists in the other make_xxx container factories. The audit found that
it does not: the other factories forward each argument as its own
deduced pack type. These tests pin that down explicitly for every
remaining factory, mirroring the make_array and make_deque regression
tests:

- make_vector, make_forward_list, make_indirect_vector (element type
  deduced via common_type): const/non-const char lvalues, element type
  checked.
- make_set, make_multiset, make_flat_set, make_flat_multiset,
  make_unordered_set, make_unordered_multiset: const/non-const lvalues
  of the key type.
- make_map, make_multimap, make_flat_map, make_flat_multimap,
  make_unordered_map, make_unordered_multimap: const/non-const lvalues
  of the pair type.

make_reference_flat_* are excluded: they cannot currently be
instantiated at all (no initializer_list constructor exists in the
reference containers), which is reported separately.

Verified with clang 22 (C++17): all 15 test suites pass (996 tests).

* Added make_forward_list parity tests matching the make_list fixes

Checked whether the make_list defect - taking its argument pack by
value, costing an extra move per lvalue argument - also applies to
make_forward_list. It does not: make_forward_list already takes its
pack by forwarding reference, as make_vector does. No header change is
needed.

Adds the two tests that accompanied the make_list fix so that
forward_list has the same coverage and the same regression detector:

- test_make_forward_list_common_type_from_mixed_types, confirming the
  element type deduction through common_type.
- test_make_forward_list_argument_copy_and_move_counts, an
  instrumented type counting copy/move constructions. This is the test
  that fails if the pack ever regresses to by-value (one extra move
  per lvalue argument). The exact move counts are C++17-only, as
  before C++17 the non-guaranteed return elision may add a move per
  element.

Verified with clang 22 (C++17): all 67 forward_list tests pass.

---------

Co-authored-by: Roland Reichwein <Roland.Reichwein@bmw.de>
2026-08-17 10:13:34 +02:00

1344 lines
40 KiB
C++

/******************************************************************************
The MIT License(MIT)
Embedded Template Library.
https://github.com/ETLCPP/etl
https://www.etlcpp.com
Copyright(c) 2015 John Wellbelove
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files(the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and / or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions :
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
******************************************************************************/
#include "unit_test_framework.h"
#include <algorithm>
#include <array>
#include <iterator>
#include <set>
#include <string>
#include <utility>
#include <vector>
#include "data.h"
#include "etl/flat_multiset.h"
namespace
{
static const size_t SIZE = 10UL;
typedef TestDataDC<std::string> DC;
typedef TestDataNDC<std::string> NDC;
typedef TestDataM<std::string> MC;
typedef etl::flat_multiset<DC, SIZE> DataDC;
typedef etl::flat_multiset<NDC, SIZE> DataNDC;
typedef etl::iflat_multiset<NDC> IDataNDC;
typedef etl::flat_multiset<int, SIZE> DataInt;
typedef etl::flat_multiset<MC, SIZE> DataM;
typedef etl::iflat_multiset<MC> IDataM;
typedef std::multiset<DC> Compare_DataDC;
typedef std::multiset<NDC> Compare_DataNDC;
struct D1
{
D1()
: a("a")
{
}
D1(const std::string& a_)
: a(a_)
{
}
std::string a;
};
struct D2
{
D2()
: a("a")
, b("b")
{
}
D2(const std::string& a_, const std::string& b_)
: a(a_)
, b(b_)
{
}
std::string a;
std::string b;
};
struct D3
{
D3()
: a("a")
, b("b")
, c("c")
{
}
D3(const std::string& a_, const std::string& b_, const std::string& c_)
: a(a_)
, b(b_)
, c(c_)
{
}
std::string a;
std::string b;
std::string c;
};
struct D4
{
D4()
: a("a")
, b("b")
, c("c")
, d("d")
{
}
D4(const std::string& a_, const std::string& b_, const std::string& c_, const std::string& d_)
: a(a_)
, b(b_)
, c(c_)
, d(d_)
{
}
std::string a;
std::string b;
std::string c;
std::string d;
};
bool operator==(const D1& lhs, const D1& rhs)
{
return (lhs.a == rhs.a);
}
bool operator==(const D2& lhs, const D2& rhs)
{
return (lhs.a == rhs.a) && (lhs.b == rhs.b);
}
bool operator==(const D3& lhs, const D3& rhs)
{
return (lhs.a == rhs.a) && (lhs.b == rhs.b) && (lhs.c == rhs.c);
}
bool operator==(const D4& lhs, const D4& rhs)
{
return (lhs.a == rhs.a) && (lhs.b == rhs.b) && (lhs.c == rhs.c) && (lhs.d == rhs.d);
}
bool operator<(const D1& lhs, const D1& rhs)
{
return (lhs.a < rhs.a);
}
bool operator<(const D2& lhs, const D2& rhs)
{
return (lhs.a < rhs.a) && (lhs.b < rhs.b);
}
bool operator<(const D3& lhs, const D3& rhs)
{
return (lhs.a < rhs.a) && (lhs.b < rhs.b) && (lhs.c < rhs.c);
}
bool operator<(const D4& lhs, const D4& rhs)
{
return (lhs.a < rhs.a) && (lhs.b < rhs.b) && (lhs.c < rhs.c) && (lhs.d < rhs.d);
}
typedef etl::flat_multiset<D1, SIZE> Data1;
typedef etl::flat_multiset<D2, SIZE> Data2;
typedef etl::flat_multiset<D3, SIZE> Data3;
typedef etl::flat_multiset<D4, SIZE> Data4;
typedef std::multiset<D1> Compare1;
typedef std::multiset<D2> Compare2;
typedef std::multiset<D3> Compare3;
typedef std::multiset<D4> Compare4;
struct Key
{
Key(const NDC& k_)
: k(k_)
{
}
NDC k;
};
bool operator<(const Key& lhs, const NDC& rhs)
{
return (lhs.k.value < rhs.value);
}
bool operator<(const NDC& lhs, const Key& rhs)
{
return (lhs.value < rhs.k.value);
}
SUITE(test_flat_multiset)
{
NDC NX = NDC("@");
NDC NY = NDC("[");
NDC N0 = NDC("A");
NDC N1 = NDC("B");
NDC N2 = NDC("C");
NDC N3 = NDC("D");
NDC N4 = NDC("E");
NDC N5 = NDC("F");
NDC N6 = NDC("G");
NDC N7 = NDC("H");
NDC N8 = NDC("I");
NDC N9 = NDC("J");
NDC N10 = NDC("K");
NDC N11 = NDC("L");
NDC N12 = NDC("M");
NDC N13 = NDC("N");
NDC N14 = NDC("O");
NDC N15 = NDC("P");
NDC N16 = NDC("Q");
NDC N17 = NDC("R");
NDC N18 = NDC("S");
NDC N19 = NDC("T");
std::vector<NDC> initial_data;
std::vector<NDC> excess_data;
std::vector<NDC> different_data;
std::vector<NDC> multi_data;
std::vector<int> int_data;
//*************************************************************************
struct SetupFixture
{
SetupFixture()
{
NDC n[] = {N0, N1, N2, N3, N4, N5, N6, N7, N8, N9};
NDC n2[] = {N0, N1, N2, N3, N4, N5, N6, N7, N8, N9, N10};
NDC n3[] = {N10, N11, N12, N13, N14, N15, N16, N17, N18, N19};
NDC n4[] = {N0, N0, N1, N2, N3, N1, N3, N3, N4, N2};
int n5[] = {10, 11, 12, 13, 14, 15, 16, 17, 18, 19};
initial_data.assign(std::begin(n), std::end(n));
excess_data.assign(std::begin(n2), std::end(n2));
different_data.assign(std::begin(n3), std::end(n3));
multi_data.assign(std::begin(n4), std::end(n4));
int_data.assign(std::begin(n5), std::end(n5));
}
};
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_default_constructor)
{
DataDC data;
CHECK_EQUAL(data.size(), 0UL);
CHECK(data.empty());
CHECK_EQUAL(data.capacity(), SIZE);
CHECK_EQUAL(data.max_size(), SIZE);
CHECK(data.begin() == data.end());
}
#if ETL_USING_CPP17 && ETL_HAS_INITIALIZER_LIST && !defined(ETL_TEMPLATE_DEDUCTION_GUIDE_TESTS_DISABLED)
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_cpp17_deduced_constructor)
{
etl::flat_multiset data{N0, N1, N2, N3, N4, N5, N6, N7, N8, N9};
etl::flat_multiset<NDC, 10U> check = {N0, N1, N2, N3, N4, N5, N6, N7, N8, N9};
CHECK(!data.empty());
CHECK(data.full());
CHECK(data.begin() != data.end());
CHECK_EQUAL(10U, data.size());
CHECK_EQUAL(0U, data.available());
CHECK_EQUAL(10U, data.capacity());
CHECK_EQUAL(10U, data.max_size());
CHECK(data == check);
}
#endif
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_destruct_via_iflat_multiset)
{
int current_count = NDC::get_instance_count();
DataNDC* pdata = new DataNDC(initial_data.begin(), initial_data.end());
CHECK_EQUAL(int(current_count + int(initial_data.size())), NDC::get_instance_count());
IDataNDC* pidata = pdata;
delete pidata;
CHECK_EQUAL(current_count, NDC::get_instance_count());
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_constructor_range)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(compare_data.begin(), compare_data.end());
CHECK(data.size() == SIZE);
CHECK(!data.empty());
}
#if ETL_HAS_INITIALIZER_LIST
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_constructor_initializer_list)
{
Compare_DataNDC compare_data = {N0, N0, N1, N2, N3, N1, N3, N3, N4, N2};
DataNDC data = {N0, N0, N1, N2, N3, N1, N3, N3, N4, N2};
CHECK_EQUAL(compare_data.size(), data.size());
CHECK(!data.empty());
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
#endif
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_move_constructor)
{
using Item = MC;
Item p1(Item("1"));
Item p2a("2a");
Item p2b("2b");
Item p3("3");
Item p4(Item("4"));
DataM data1;
data1.insert(std::move(p1));
data1.insert(std::move(p2a));
data1.insert(std::move(p3));
data1.insert(std::move(p4));
data1.insert(std::move(p2b));
CHECK(!bool(p1));
CHECK(!bool(p2a));
CHECK(!bool(p2b));
CHECK(!bool(p3));
CHECK(!bool(p4));
DataM data2(std::move(data1));
CHECK_EQUAL(5U, data1.size()); // Move does not clear the source.
CHECK_EQUAL(5U, data2.size());
DataM::iterator itr = data2.begin();
Item pr = std::move(*itr++);
CHECK_EQUAL("1", pr.value);
CHECK_EQUAL("2a", (*itr++).value);
CHECK_EQUAL("2b", (*itr++).value);
CHECK_EQUAL("3", (*itr++).value);
CHECK_EQUAL("4", (*itr++).value);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_assignment)
{
DataNDC data(initial_data.begin(), initial_data.end());
DataNDC other_data;
other_data = data;
bool isEqual = std::equal(data.begin(), data.end(), other_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_assignment_interface)
{
DataNDC data1(initial_data.begin(), initial_data.end());
DataNDC data2;
IDataNDC& idata1 = data1;
IDataNDC& idata2 = data2;
idata2 = idata1;
bool isEqual = std::equal(data1.begin(), data1.end(), data2.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_self_assignment)
{
DataNDC data(initial_data.begin(), initial_data.end());
DataNDC other_data(data);
#include "etl/private/diagnostic_self_assign_overloaded_push.h"
other_data = other_data;
#include "etl/private/diagnostic_pop.h"
bool isEqual = std::equal(data.begin(), data.end(), other_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_begin)
{
DataNDC data(initial_data.begin(), initial_data.end());
const DataNDC constData(data);
CHECK(data.begin() == std::begin(data));
CHECK(constData.begin() == std::begin(constData));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_end)
{
DataNDC data(initial_data.begin(), initial_data.end());
const DataNDC constData(data);
CHECK(data.end() == std::end(data));
CHECK(constData.end() == std::end(constData));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_empty)
{
DataNDC data;
data.insert(initial_data.begin(), initial_data.end());
CHECK(data.full());
CHECK(!data.empty());
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_full)
{
DataNDC data;
CHECK(!data.full());
CHECK(data.empty());
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_assign_range)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data;
data.assign(compare_data.begin(), compare_data.end());
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
CHECK(std::is_sorted(data.begin(), data.end()));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_insert_value)
{
Compare_DataNDC compare_data;
DataNDC data;
data.insert(N0);
compare_data.insert(N0);
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
data.insert(N2);
compare_data.insert(N2);
isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
data.insert(N1);
compare_data.insert(N1);
isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
CHECK(std::is_sorted(data.begin(), data.end()));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_insert_value_multiple)
{
Compare_DataNDC compare_data;
DataNDC data;
data.insert(N0);
compare_data.insert(N0);
data.insert(N1);
compare_data.insert(N1);
data.insert(N2);
compare_data.insert(N2);
// Do it again.
data.insert(N0);
compare_data.insert(N0);
data.insert(N1);
compare_data.insert(N1);
data.insert(N2);
compare_data.insert(N2);
CHECK_EQUAL(compare_data.size(), data.size());
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
CHECK(std::is_sorted(data.begin(), data.end()));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_insert_value_excess)
{
DataNDC data(initial_data.begin(), initial_data.end());
CHECK_THROW(data.insert(N10), etl::flat_multiset_full);
CHECK(std::is_sorted(data.begin(), data.end()));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_insert_range)
{
Compare_DataNDC compare_data;
DataNDC data;
data.insert(initial_data.begin(), initial_data.end());
compare_data.insert(initial_data.begin(), initial_data.end());
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
CHECK(std::is_sorted(data.begin(), data.end()));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_insert_range_excess)
{
DataNDC data;
CHECK_THROW(data.insert(excess_data.begin(), excess_data.end()), etl::flat_multiset_full);
CHECK(std::is_sorted(data.begin(), data.end()));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_emplace_default_value)
{
Compare1 compare;
Data1 data;
data.emplace();
compare.emplace();
data.emplace();
compare.emplace();
data.emplace();
compare.emplace();
// Do it again.
data.emplace();
compare.emplace();
data.emplace();
compare.emplace();
data.emplace();
compare.emplace();
CHECK_EQUAL(compare.size(), data.size());
bool isEqual = std::equal(data.begin(), data.end(), compare.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_emplace_value1)
{
Compare1 compare;
Data1 data;
data.emplace("0");
compare.emplace("0");
data.emplace("1");
compare.emplace("1");
data.emplace("2");
compare.emplace("2");
// Do it again.
data.emplace("0");
compare.emplace("0");
data.emplace("1");
compare.emplace("1");
data.emplace("2");
compare.emplace("2");
CHECK_EQUAL(compare.size(), data.size());
bool isEqual = std::equal(data.begin(), data.end(), compare.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_emplace_value2)
{
Compare2 compare;
Data2 data;
data.emplace("0", "1");
compare.emplace("0", "1");
data.emplace("1", "2");
compare.emplace("1", "2");
data.emplace("2", "3");
compare.emplace("2", "3");
// Do it again.
data.emplace("0", "1");
compare.emplace("0", "1");
data.emplace("1", "2");
compare.emplace("1", "2");
data.emplace("2", "3");
compare.emplace("2", "3");
CHECK_EQUAL(compare.size(), data.size());
bool isEqual = std::equal(data.begin(), data.end(), compare.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_emplace_value3)
{
Compare3 compare;
Data3 data;
data.emplace("0", "1", "2");
compare.emplace("0", "1", "2");
data.emplace("1", "2", "3");
compare.emplace("1", "2", "3");
data.emplace("2", "3", "4");
compare.emplace("2", "3", "4");
// Do it again.
data.emplace("0", "1", "2");
compare.emplace("0", "1", "2");
data.emplace("1", "2", "3");
compare.emplace("1", "2", "3");
data.emplace("2", "3", "4");
compare.emplace("2", "3", "4");
CHECK_EQUAL(compare.size(), data.size());
bool isEqual = std::equal(data.begin(), data.end(), compare.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_emplace_value4)
{
Compare4 compare;
Data4 data;
data.emplace("0", "1", "2", "3");
compare.emplace("0", "1", "2", "3");
data.emplace("1", "2", "3", "4");
compare.emplace("1", "2", "3", "4");
data.emplace("2", "3", "4", "5");
compare.emplace("2", "3", "4", "5");
// Do it again.
data.emplace("0", "1", "2", "3");
compare.emplace("0", "1", "2", "3");
data.emplace("1", "2", "3", "4");
compare.emplace("1", "2", "3", "4");
data.emplace("2", "3", "4", "5");
compare.emplace("2", "3", "4", "5");
CHECK_EQUAL(compare.size(), data.size());
bool isEqual = std::equal(data.begin(), data.end(), compare.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_emplace_excess)
{
DataNDC data(initial_data.begin(), initial_data.end());
CHECK_THROW(data.emplace(N10), etl::flat_multiset_full);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_erase_key)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
size_t count_compare = compare_data.erase(N5);
size_t count = data.erase(N5);
CHECK_EQUAL(count_compare, count);
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_erase_key_using_transparent_comparator)
{
using CSet = std::multiset<NDC>;
CSet compare_data(initial_data.begin(), initial_data.end());
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
size_t count_compare = compare_data.erase(N5);
size_t count = data.erase(Key(N5));
CHECK_EQUAL(count_compare, count);
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_erase_single_iterator)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
Compare_DataNDC::iterator i_compare_begin = compare_data.begin();
DataNDC::iterator i_data_begin = data.begin();
Compare_DataNDC::iterator i_compare = i_compare_begin;
DataNDC::iterator i_data = i_data_begin;
Compare_DataNDC::iterator i_compare_expected = i_compare_begin;
DataNDC::iterator i_data_expected = i_data_begin;
std::advance(i_compare, 2);
std::advance(i_data, 2);
std::advance(i_compare_expected, 3);
std::advance(i_data_expected, 3);
NDC compare_expected = *i_compare_expected;
NDC data_expected = *i_data_expected;
Compare_DataNDC::iterator i_compare_result = compare_data.erase(i_compare);
DataNDC::iterator i_data_result = data.erase(i_data);
CHECK(compare_expected == *i_compare_result);
CHECK(data_expected == *i_data_result);
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_erase_single_const_iterator)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
Compare_DataNDC::iterator i_compare_begin = compare_data.begin();
DataNDC::iterator i_data_begin = data.begin();
Compare_DataNDC::const_iterator i_compare = i_compare_begin;
DataNDC::const_iterator i_data = i_data_begin;
Compare_DataNDC::iterator i_compare_expected = i_compare_begin;
DataNDC::iterator i_data_expected = i_data_begin;
std::advance(i_compare, 2);
std::advance(i_data, 2);
std::advance(i_compare_expected, 3);
std::advance(i_data_expected, 3);
NDC compare_expected = *i_compare_expected;
NDC data_expected = *i_data_expected;
Compare_DataNDC::iterator i_compare_result = compare_data.erase(i_compare);
DataNDC::iterator i_data_result = data.erase(i_data);
CHECK(compare_expected == *i_compare_result);
CHECK(data_expected == *i_data_result);
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_erase_range)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
Compare_DataNDC::const_iterator i_compare = compare_data.begin();
DataNDC::const_iterator i_data = data.begin();
Compare_DataNDC::const_iterator i_compare_end = compare_data.begin();
DataNDC::const_iterator i_data_end = data.begin();
std::advance(i_compare, 2);
std::advance(i_data, 2);
std::advance(i_compare_end, 4);
std::advance(i_data_end, 4);
NDC compare_expected = *i_compare_end;
NDC data_expected = *i_data_end;
Compare_DataNDC::iterator i_compare_result = compare_data.erase(i_compare, i_compare_end);
DataNDC::iterator i_data_result = data.erase(i_data, i_data_end);
CHECK(compare_expected == *i_compare_result);
CHECK(data_expected == *i_data_result);
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_clear)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(compare_data.begin(), compare_data.end());
data.clear();
CHECK_EQUAL(data.size(), 0UL);
// Do it again to check that clear() didn't screw up the internals.
data.assign(compare_data.begin(), compare_data.end());
CHECK_EQUAL(data.size(), compare_data.size());
data.clear();
CHECK_EQUAL(data.size(), 0UL);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_clear_pod)
{
DataInt data(int_data.begin(), int_data.end());
data.clear();
CHECK_EQUAL(data.size(), 0UL);
// Do it again to check that clear() didn't screw up the internals.
data.assign(int_data.begin(), int_data.end());
CHECK_EQUAL(data.size(), int_data.size());
data.clear();
CHECK_EQUAL(data.size(), 0UL);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_iterator)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(compare_data.begin(), compare_data.end());
bool isEqual = std::equal(data.begin(), data.end(), compare_data.begin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_const_iterator)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(compare_data.begin(), compare_data.end());
bool isEqual = std::equal(data.cbegin(), data.cend(), compare_data.cbegin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_reverse_iterator)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(compare_data.begin(), compare_data.end());
bool isEqual = std::equal(data.rbegin(), data.rend(), compare_data.rbegin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_const_reverse_iterator)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(compare_data.begin(), compare_data.end());
bool isEqual = std::equal(data.crbegin(), data.crend(), compare_data.crbegin());
CHECK(isEqual);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find)
{
DataNDC data(initial_data.begin(), initial_data.end());
DataNDC::iterator it = data.find(N3);
CHECK_EQUAL(N3, *it);
it = data.find(N19);
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_using_transparent_comparator)
{
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
ESet::iterator it = data.find(Key(N3));
CHECK_EQUAL(N3, *it);
it = data.find(N19);
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_not_present)
{
DataNDC data(initial_data.begin(), initial_data.end());
DataNDC::iterator it = data.find(NX);
CHECK(data.end() == it);
it = data.find(NY);
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_not_present_using_transparent_comparator)
{
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
ESet::iterator it = data.find(Key(NX));
CHECK(data.end() == it);
it = data.find(Key(NY));
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_const)
{
const DataNDC data(initial_data.begin(), initial_data.end());
DataNDC::const_iterator it = data.find(N3);
CHECK_EQUAL(N3, *it);
it = data.find(N19);
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_const_using_transparent_comparator)
{
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
const ESet data(initial_data.begin(), initial_data.end());
ESet::const_iterator it = data.find(Key(N3));
CHECK_EQUAL(N3, *it);
it = data.find(Key(N19));
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_const_not_present)
{
const DataNDC data(initial_data.begin(), initial_data.end());
DataNDC::const_iterator it = data.find(NX);
CHECK(data.end() == it);
it = data.find(NY);
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_find_const_not_present_using_transparent_comparator)
{
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
const ESet data(initial_data.begin(), initial_data.end());
ESet::const_iterator it = data.find(Key(NX));
CHECK(data.end() == it);
it = data.find(Key(NY));
CHECK(data.end() == it);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_lower_bound)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
Compare_DataNDC::iterator i_compare = compare_data.lower_bound(N5);
DataNDC::iterator i_data = data.lower_bound(N5);
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare), std::distance(data.begin(), i_data));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_lower_bound_using_transparent_comparator)
{
using CSet = std::multiset<NDC>;
CSet compare_data(initial_data.begin(), initial_data.end());
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
CSet::iterator i_compare = compare_data.lower_bound(N5);
ESet::iterator i_data = data.lower_bound(Key(N5));
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare), std::distance(data.begin(), i_data));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_upper_bound)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
Compare_DataNDC::iterator i_compare = compare_data.upper_bound(N5);
DataNDC::iterator i_data = data.upper_bound(N5);
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare), std::distance(data.begin(), i_data));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_upper_bound_using_transparent_comparator)
{
using CSet = std::multiset<NDC>;
CSet compare_data(initial_data.begin(), initial_data.end());
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
CSet::iterator i_compare = compare_data.upper_bound(N5);
ESet::iterator i_data = data.upper_bound(Key(N5));
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare), std::distance(data.begin(), i_data));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_equal_range)
{
Compare_DataNDC compare_data(initial_data.begin(), initial_data.end());
DataNDC data(initial_data.begin(), initial_data.end());
ETL_OR_STD::pair<Compare_DataNDC::iterator, Compare_DataNDC::iterator> i_compare = compare_data.equal_range(N5);
ETL_OR_STD::pair<DataNDC::iterator, DataNDC::iterator> i_data = data.equal_range(N5);
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare.first), std::distance(data.begin(), i_data.first));
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare.second), std::distance(data.begin(), i_data.second));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_equal_range_using_transparent_comparator)
{
using CSet = std::multiset<NDC>;
CSet compare_data(initial_data.begin(), initial_data.end());
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
ETL_OR_STD::pair<CSet::iterator, CSet::iterator> i_compare = compare_data.equal_range(N5);
ETL_OR_STD::pair<ESet::iterator, ESet::iterator> i_data = data.equal_range(Key(N5));
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare.first), std::distance(data.begin(), i_data.first));
CHECK_EQUAL(std::distance(compare_data.begin(), i_compare.second), std::distance(data.begin(), i_data.second));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_equal_range_not_present)
{
DataNDC data(initial_data.begin(), initial_data.end());
ETL_OR_STD::pair<DataNDC::iterator, DataNDC::iterator> i_data;
i_data = data.equal_range(NX);
CHECK(data.begin() == i_data.first);
CHECK(data.begin() == i_data.second);
i_data = data.equal_range(NY);
CHECK(data.end() == i_data.first);
CHECK(data.end() == i_data.second);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_equal_range_not_present_using_transparent_comparator)
{
using ESet = etl::flat_multiset<NDC, SIZE, etl::less<>>;
ESet data(initial_data.begin(), initial_data.end());
ETL_OR_STD::pair<ESet::iterator, ESet::iterator> i_data;
i_data = data.equal_range(Key(NX));
CHECK(data.begin() == i_data.first);
CHECK(data.begin() == i_data.second);
i_data = data.equal_range(Key(NY));
CHECK(data.end() == i_data.first);
CHECK(data.end() == i_data.second);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_equal)
{
const DataNDC initial1(initial_data.begin(), initial_data.end());
const DataNDC initial2(initial_data.begin(), initial_data.end());
CHECK(initial1 == initial2);
const DataNDC different(different_data.begin(), different_data.end());
CHECK(!(initial1 == different));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_not_equal)
{
const DataNDC initial1(initial_data.begin(), initial_data.end());
const DataNDC initial2(initial_data.begin(), initial_data.end());
CHECK(!(initial1 != initial2));
const DataNDC different(different_data.begin(), different_data.end());
CHECK(initial1 != different);
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_multi)
{
Compare_DataNDC compare_data(multi_data.begin(), multi_data.end());
DataNDC data(multi_data.begin(), multi_data.end());
ETL_OR_STD::pair<Compare_DataNDC::iterator, Compare_DataNDC::iterator> compare_range;
ETL_OR_STD::pair<DataNDC::iterator, DataNDC::iterator> test_range;
compare_range = compare_data.equal_range(N0);
test_range = data.equal_range(N0);
CHECK_EQUAL(std::distance(compare_range.first, compare_range.second), std::distance(test_range.first, test_range.second));
compare_range = compare_data.equal_range(N1);
test_range = data.equal_range(N1);
CHECK_EQUAL(std::distance(compare_range.first, compare_range.second), std::distance(test_range.first, test_range.second));
compare_range = compare_data.equal_range(N2);
test_range = data.equal_range(N2);
CHECK_EQUAL(std::distance(compare_range.first, compare_range.second), std::distance(test_range.first, test_range.second));
compare_range = compare_data.equal_range(N3);
test_range = data.equal_range(N3);
CHECK_EQUAL(std::distance(compare_range.first, compare_range.second), std::distance(test_range.first, test_range.second));
compare_range = compare_data.equal_range(N4);
test_range = data.equal_range(N4);
CHECK_EQUAL(std::distance(compare_range.first, compare_range.second), std::distance(test_range.first, test_range.second));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_count)
{
Compare_DataNDC compare_data(multi_data.begin(), multi_data.end());
DataNDC data(multi_data.begin(), multi_data.end());
CHECK_EQUAL(compare_data.count(N0), data.count(N0));
CHECK_EQUAL(compare_data.count(N1), data.count(N1));
CHECK_EQUAL(compare_data.count(N2), data.count(N2));
CHECK_EQUAL(compare_data.count(N3), data.count(N3));
CHECK_EQUAL(compare_data.count(N4), data.count(N4));
}
//*************************************************************************
#if ETL_USING_CPP17 && ETL_HAS_INITIALIZER_LIST && !defined(ETL_TEMPLATE_DEDUCTION_GUIDE_TESTS_DISABLED)
TEST_FIXTURE(SetupFixture, test_flat_set_template_deduction)
{
etl::flat_multiset data{NDC("A"), NDC("B"), NDC("B2"), NDC("C"), NDC("D"), NDC("E"), NDC("F")};
auto v = *data.begin();
using Type = decltype(v);
CHECK((std::is_same_v<NDC, Type>));
decltype(data)::const_iterator itr = data.begin();
CHECK_EQUAL(NDC("A"), *itr);
++itr;
CHECK_EQUAL(NDC("B"), *itr);
++itr;
CHECK_EQUAL(NDC("B2"), *itr);
++itr;
CHECK_EQUAL(NDC("C"), *itr);
++itr;
CHECK_EQUAL(NDC("D"), *itr);
++itr;
CHECK_EQUAL(NDC("E"), *itr);
++itr;
CHECK_EQUAL(NDC("F"), *itr);
}
#endif
//*************************************************************************
#if ETL_HAS_INITIALIZER_LIST
TEST_FIXTURE(SetupFixture, test_make_flat_multiset)
{
auto data = etl::make_flat_multiset<NDC>(NDC("A"), NDC("B"), NDC("B2"), NDC("C"), NDC("D"), NDC("E"), NDC("F"));
auto v = *data.begin();
using Type = decltype(v);
CHECK((std::is_same<NDC, Type>::value));
decltype(data)::const_iterator itr = data.begin();
CHECK_EQUAL(NDC("A"), *itr);
++itr;
CHECK_EQUAL(NDC("B"), *itr);
++itr;
CHECK_EQUAL(NDC("B2"), *itr);
++itr;
CHECK_EQUAL(NDC("C"), *itr);
++itr;
CHECK_EQUAL(NDC("D"), *itr);
++itr;
CHECK_EQUAL(NDC("E"), *itr);
++itr;
CHECK_EQUAL(NDC("F"), *itr);
}
#endif
//*************************************************************************
#if ETL_HAS_INITIALIZER_LIST
// Arguments that are const-qualified lvalues of the key type must be
// accepted. Guards against the defect fixed for make_array and make_deque,
// which forwarded each argument as the element type rather than as its own
// deduced type and so rejected const lvalues.
TEST_FIXTURE(SetupFixture, test_make_flat_multiset_from_const_lvalues_of_key_type)
{
static const char static_const_lvalue = 42;
const char local_const_lvalue = 43;
char mutable_lvalue = 44;
auto data = etl::make_flat_multiset<char>(static_const_lvalue, local_const_lvalue, mutable_lvalue);
auto v = *data.begin();
using Type = decltype(v);
CHECK((std::is_same<char, Type>::value));
decltype(data)::const_iterator itr = data.begin();
CHECK_EQUAL(42, *itr);
++itr;
CHECK_EQUAL(43, *itr);
++itr;
CHECK_EQUAL(44, *itr);
}
#endif
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_contains)
{
DataNDC data(initial_data.begin(), initial_data.end());
CHECK(data.contains(N5));
CHECK(!data.contains(NX));
}
//*************************************************************************
TEST_FIXTURE(SetupFixture, test_contains_with_transparent_comparator)
{
using EMap = etl::flat_multiset<NDC, SIZE, etl::less<>>;
EMap data(initial_data.begin(), initial_data.end());
CHECK(data.contains(Key(N5)));
CHECK(!data.contains(Key(NX)));
}
}
} // namespace