coffee/fast_float
1
0
Fork 0
mirror of https://github.com/fastfloat/fast_float.git synced 2026-06-15 00:16:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #391 from sahvx655-wq/int-fast-path-wide-units

Browse Source 
reject non-digit wide code units in uint8/uint16 integer fast path
This commit is contained in:
Daniel Lemire 2026-06-11 20:28:10 -04:00 committed by GitHub
commit 0dce102cb4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 61 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/fast_float/ascii_number.h
View File

@ -600,7 +600,8 @@ parse_int_string(UC const *p, UC const *pend, T &value,
UC const *const start_digits = p;
FASTFLOAT_IF_CONSTEXPR17((std::is_same<T, std::uint8_t>::value)) {
FASTFLOAT_IF_CONSTEXPR17((std::is_same<T, std::uint8_t>::value &&
sizeof(UC) == 1)) {
if (base == 10) {
const size_t len = (size_t)(pend - p);
if (len == 0) {
@ -692,7 +693,8 @@ parse_int_string(UC const *p, UC const *pend, T &value,
}
}
FASTFLOAT_IF_CONSTEXPR17((std::is_same<T, std::uint16_t>::value)) {
FASTFLOAT_IF_CONSTEXPR17((std::is_same<T, std::uint16_t>::value &&
sizeof(UC) == 1)) {
if (base == 10) {
const size_t len = size_t(pend - p);
if (len == 0) {

57
tests/fast_int.cpp
View File

@ -1295,6 +1295,63 @@ int main() {
return EXIT_FAILURE;
}
}
// The uint8_t and uint16_t base-10 paths use a byte-oriented fast path. A
// wider code unit whose low byte is an ASCII digit (e.g. U+2131..U+2139) must
// not be mistaken for that digit. The generic path already rejects these for
// int; the fixed-width fast paths must agree. Lengths of 1..5 exercise both
// the uint8_t path and the 4-digit uint16_t SWAR path.
{
const std::u16string bad16[] = {
u"ℹ",
u"ℱℲ",
u"ℱℲℳ",
u"ℱℲℳℴ",
u"ℱℲℳℴℵ",
};
const std::u32string bad32[] = {
U"ℹ",
U"ℱℲℳ",
U"ℱℲℳℴ",
U"ℱℲℳℴℵ",
};
bool failed = false;
for (auto const &s : bad16) {
uint8_t r8 = 123;
auto a8 = fast_float::from_chars(s.data(), s.data() + s.size(), r8);
if (a8.ec == std::errc()) {
failed = true;
std::cerr << "Incorrectly parsed wide units as uint8_t " << unsigned(r8)
<< "." << std::endl;
}
uint16_t r16 = 123;
auto a16 = fast_float::from_chars(s.data(), s.data() + s.size(), r16);
if (a16.ec == std::errc()) {
failed = true;
std::cerr << "Incorrectly parsed wide units as uint16_t " << r16 << "."
<< std::endl;
}
}
for (auto const &s : bad32) {
uint8_t r8 = 123;
auto a8 = fast_float::from_chars(s.data(), s.data() + s.size(), r8);
if (a8.ec == std::errc()) {
failed = true;
std::cerr << "Incorrectly parsed wide units as uint8_t " << unsigned(r8)
<< "." << std::endl;
}
uint16_t r16 = 123;
auto a16 = fast_float::from_chars(s.data(), s.data() + s.size(), r16);
if (a16.ec == std::errc()) {
failed = true;
std::cerr << "Incorrectly parsed wide units as uint16_t " << r16 << "."
<< std::endl;
}
}
if (failed) {
return EXIT_FAILURE;
}
}
return EXIT_SUCCESS;
}