From 363141fc43cd09b2473931612031c04b3b5d40e9 Mon Sep 17 00:00:00 2001 From: HedgehogInTheCPP Date: Fri, 21 Aug 2026 21:11:24 +0300 Subject: [PATCH] Improvements detection of features, part 7. Visual Studio 17 naming fix. --- .github/workflows/vs17-arm-ci.yml | 4 ++-- .github/workflows/vs17-ci.yml | 8 ++++---- .github/workflows/vs17-clang-ci.yml | 8 ++++---- .github/workflows/vs17-cxx20.yml | 8 ++++---- include/fast_float/constexpr_feature_detect.h | 4 +++- 5 files changed, 17 insertions(+), 15 deletions(-) diff --git a/.github/workflows/vs17-arm-ci.yml b/.github/workflows/vs17-arm-ci.yml index 32a4f63..3d0c9d8 100644 --- a/.github/workflows/vs17-arm-ci.yml +++ b/.github/workflows/vs17-arm-ci.yml @@ -10,8 +10,8 @@ jobs: fail-fast: false matrix: include: - - {gen: Visual Studio 17 2026, arch: ARM64, cfg: Release} - - {gen: Visual Studio 17 2026, arch: ARM64, cfg: Debug} + - {gen: Visual Studio 17 2022, arch: ARM64, cfg: Release} + - {gen: Visual Studio 17 2022, arch: ARM64, cfg: Debug} steps: - name: checkout uses: actions/checkout@v7 diff --git a/.github/workflows/vs17-ci.yml b/.github/workflows/vs17-ci.yml index 6c1ec6b..8f45372 100644 --- a/.github/workflows/vs17-ci.yml +++ b/.github/workflows/vs17-ci.yml @@ -10,10 +10,10 @@ jobs: fail-fast: false matrix: include: - - {gen: Visual Studio 17 2026, arch: Win32, cfg: Release} - - {gen: Visual Studio 17 2026, arch: Win32, cfg: Debug} - - {gen: Visual Studio 17 2026, arch: x64, cfg: Release} - - {gen: Visual Studio 17 2026, arch: x64, cfg: Debug} + - {gen: Visual Studio 17 2022, arch: Win32, cfg: Release} + - {gen: Visual Studio 17 2022, arch: Win32, cfg: Debug} + - {gen: Visual Studio 17 2022, arch: x64, cfg: Release} + - {gen: Visual Studio 17 2022, arch: x64, cfg: Debug} steps: - name: checkout uses: actions/checkout@v7 diff --git a/.github/workflows/vs17-clang-ci.yml b/.github/workflows/vs17-clang-ci.yml index 4cec9df..76a8b1a 100644 --- a/.github/workflows/vs17-clang-ci.yml +++ b/.github/workflows/vs17-clang-ci.yml @@ -10,10 +10,10 @@ jobs: fail-fast: false matrix: include: - - {gen: Visual Studio 18 2026, arch: Win32, cfg: Release} - - {gen: Visual Studio 18 2026, arch: Win32, cfg: Debug} - - {gen: Visual Studio 18 2026, arch: x64, cfg: Release} - - {gen: Visual Studio 18 2026, arch: x64, cfg: Debug} + - {gen: Visual Studio 18 2022, arch: Win32, cfg: Release} + - {gen: Visual Studio 18 2022, arch: Win32, cfg: Debug} + - {gen: Visual Studio 18 2022, arch: x64, cfg: Release} + - {gen: Visual Studio 18 2022, arch: x64, cfg: Debug} steps: - name: checkout uses: actions/checkout@v7 diff --git a/.github/workflows/vs17-cxx20.yml b/.github/workflows/vs17-cxx20.yml index f6565a4..2a064af 100644 --- a/.github/workflows/vs17-cxx20.yml +++ b/.github/workflows/vs17-cxx20.yml @@ -10,10 +10,10 @@ jobs: fail-fast: false matrix: include: - - {gen: Visual Studio 17 2026, arch: Win32, cfg: Release} - - {gen: Visual Studio 17 2026, arch: Win32, cfg: Debug} - - {gen: Visual Studio 17 2026, arch: x64, cfg: Release} - - {gen: Visual Studio 17 2026, arch: x64, cfg: Debug} + - {gen: Visual Studio 17 2022, arch: Win32, cfg: Release} + - {gen: Visual Studio 17 2022, arch: Win32, cfg: Debug} + - {gen: Visual Studio 17 2022, arch: x64, cfg: Release} + - {gen: Visual Studio 17 2022, arch: x64, cfg: Debug} steps: - name: checkout uses: actions/checkout@v7 diff --git a/include/fast_float/constexpr_feature_detect.h b/include/fast_float/constexpr_feature_detect.h index 0017ce1..87f8e3c 100644 --- a/include/fast_float/constexpr_feature_detect.h +++ b/include/fast_float/constexpr_feature_detect.h @@ -70,7 +70,9 @@ #endif // C++20 std::is_constant_evaluated -#if defined(__cpp_lib_is_constant_evaluated) && __cpp_lib_is_constant_evaluated >= 201811L && defined(__cpp_consteval) && __cpp_consteval >= 201811L +#if defined(__cpp_lib_is_constant_evaluated) && \ + __cpp_lib_is_constant_evaluated >= 201811L && defined(__cpp_consteval) && \ + __cpp_consteval >= 201811L #define FASTFLOAT_HAS_IS_CONSTANT_EVALUATED 1 #define FASTFLOAT_CONSTEVAL consteval #else