From fe8e477e14d7a9e8c10d17eb8bb832e5e58badee Mon Sep 17 00:00:00 2001
From: "Benjamin A. Beasley" <code@musicinmybrain.net>
Date: Mon, 21 Jun 2021 11:20:01 -0400
Subject: [PATCH] Add a SYSTEM_DOCTEST CMake option
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This option is off by default, maintaining the previous behavior. When
enabled (along with FASTFLOAT_TEST), it bypasses the FetchContent
machinery for doctest so that a system-wide installation of the doctest
header can be easily used. In this case, the header doctest/doctest.h
should be available on the compiler’s include path.

This option is especially useful for Linux distributions and others that
need to run the tests in fully offline build environments.

Fixes #83.
---
 tests/CMakeLists.txt | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 6b703e0..24101e3 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -4,9 +4,13 @@ cmake_minimum_required(VERSION 3.11 FATAL_ERROR)
 
 include(FetchContent)
 
-FetchContent_Declare(doctest
-  GIT_REPOSITORY https://github.com/onqtam/doctest.git
-  GIT_TAG 2.4.6)
+option(SYSTEM_DOCTEST "Use system copy of doctest" OFF)
+
+if (NOT SYSTEM_DOCTEST)
+  FetchContent_Declare(doctest
+    GIT_REPOSITORY https://github.com/onqtam/doctest.git
+    GIT_TAG 2.4.6)
+endif()
 FetchContent_Declare(supplemental_test_files
   GIT_REPOSITORY https://github.com/fastfloat/supplemental_test_files.git
   GIT_TAG origin/main)
@@ -16,10 +20,12 @@ FetchContent_Declare(supplemental_test_files
 # FetchContent_MakeAvailable() was only introduced in 3.14
 # https://cmake.org/cmake/help/v3.14/release/3.14.html#modules
 # FetchContent_MakeAvailable(doctest)
-FetchContent_GetProperties(doctest)
-if(NOT doctest_POPULATED)
-  FetchContent_Populate(doctest)
-  add_subdirectory(${doctest_SOURCE_DIR} ${doctest_BINARY_DIR})
+if (NOT SYSTEM_DOCTEST)
+  FetchContent_GetProperties(doctest)
+  if(NOT doctest_POPULATED)
+    FetchContent_Populate(doctest)
+    add_subdirectory(${doctest_SOURCE_DIR} ${doctest_BINARY_DIR})
+  endif()
 endif()
 FetchContent_GetProperties(supplemental_test_files)
 if(NOT supplemental_test_files_POPULATED)
@@ -40,7 +46,10 @@ function(fast_float_add_cpp_test TEST_NAME)
       target_compile_options(${TEST_NAME} PUBLIC -Werror -Wall -Wextra -Weffc++)
       target_compile_options(${TEST_NAME} PUBLIC -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wsign-conversion)
     endif()
-    target_link_libraries(${TEST_NAME} PUBLIC fast_float doctest supplemental-data)
+    target_link_libraries(${TEST_NAME} PUBLIC fast_float supplemental-data)
+    if (NOT SYSTEM_DOCTEST)
+      target_link_libraries(${TEST_NAME} PUBLIC doctest)
+    endif()
 endfunction(fast_float_add_cpp_test)
 
 
@@ -65,4 +74,4 @@ if (FASTFLOAT_EXHAUSTIVE)
   fast_float_add_cpp_test(random64)
 endif(FASTFLOAT_EXHAUSTIVE)
 
-add_subdirectory(build_tests)
\ No newline at end of file
+add_subdirectory(build_tests)