coffee/fmt
1
0
Fork 0
mirror of https://github.com/fmtlib/fmt.git synced 2026-07-30 16:26:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed {:c} formatting with negative integrals

Browse Source 
std::format uses the two's complement for formatting while
   FML used the absolute value, failing to correctly write when
   using values like -104 (FMT used 104 while std uses 152)
This commit is contained in:
David Xchel Morales Hurtado 2026-07-10 21:45:05 -06:00
parent 6dac6cad05
commit d34e749f6e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/fmt/format.h
View File

@ -2124,6 +2124,10 @@ FMT_CONSTEXPR FMT_INLINE auto write_int(OutputIt out, write_int_arg<T> arg,
prefix_append(prefix, unsigned(specs.upper() ? 'B' : 'b') << 8 | '0');
break;
case presentation_type::chr:
// Handles negative cases on casts to smaller types using Two's complement
// One example is int{-104} to char which std::format uses as 152
if (sizeof(Char) < sizeof(abs_value) && (arg.prefix & 0xff) == '-')
abs_value = (1 << (8*sizeof(Char))) - abs_value;
return write_char<Char>(out, static_cast<Char>(abs_value), specs);
}