diff --git a/include/fmt/ranges.h b/include/fmt/ranges.h index ff682a8f..d7dbc168 100644 --- a/include/fmt/ranges.h +++ b/include/fmt/ranges.h @@ -844,7 +844,7 @@ FMT_CONSTEXPR auto join(const Tuple& tuple FMT_LIFETIMEBOUND, string_view sep) * // Output: "1, 2, 3" */ template -auto join(std::initializer_list list, string_view sep) +FMT_DEPRECATED auto join(std::initializer_list list, string_view sep) -> join_view { return join(std::begin(list), std::end(list), sep); } diff --git a/include/fmt/xchar.h b/include/fmt/xchar.h index dad64357..31706f96 100644 --- a/include/fmt/xchar.h +++ b/include/fmt/xchar.h @@ -160,7 +160,7 @@ auto join(Range&& range, S&& sep) } template -auto join(std::initializer_list list, wstring_view sep) +FMT_DEPRECATED auto join(std::initializer_list list, wstring_view sep) -> join_view { return join(std::begin(list), std::end(list), sep); } diff --git a/test/ranges-test.cc b/test/ranges-test.cc index 9ff6b9b1..7ec0d76c 100644 --- a/test/ranges-test.cc +++ b/test/ranges-test.cc @@ -433,12 +433,6 @@ TEST(ranges_test, join_tuple) { #endif } -TEST(ranges_test, join_initializer_list) { - EXPECT_EQ(fmt::format("{}", fmt::join({1, 2, 3}, ", ")), "1, 2, 3"); - EXPECT_EQ(fmt::format("{}", fmt::join({"fmt", "rocks", "!"}, " ")), - "fmt rocks !"); -} - struct zstring_sentinel {}; bool operator==(const char* p, zstring_sentinel) { return *p == '\0'; } diff --git a/test/xchar-test.cc b/test/xchar-test.cc index 87aad4a1..cfe8389d 100644 --- a/test/xchar-test.cc +++ b/test/xchar-test.cc @@ -174,7 +174,6 @@ TEST(xchar_test, join) { EXPECT_EQ(fmt::format(u"({})", fmt::join(vector, u", ")), u"(1, 2, 3)"); EXPECT_EQ(fmt::format(U"({})", fmt::join(vector, U", ")), U"(1, 2, 3)"); EXPECT_EQ(fmt::format(L"({})", fmt::join(vector, L", ")), L"(1, 2, 3)"); - EXPECT_EQ(fmt::format(L"({})", fmt::join({1, 2, 3}, L", ")), L"(1, 2, 3)"); auto tuple_char16 = std::tuple(u'a', 1, 2.0f); EXPECT_EQ(fmt::format(u"({})", fmt::join(tuple_char16, u", ")), u"(a, 1, 2)"); auto tuple_char32 = std::tuple(U'a', 1, 2.0f);