From e5d13d826f4266de65d2463dc3bff4ff3d25221e Mon Sep 17 00:00:00 2001 From: Tiago Date: Fri, 11 Sep 2026 12:39:06 -0700 Subject: [PATCH] Make nolocale-test actually disable locale (#4939) nolocale-test defines FMT_STATIC_THOUSANDS_SEPARATOR, which stopped doing anything in b90b4bc9 ("Remove FMT_STATIC_THOUSANDS_SEPARATOR in favor of FMT_USE_LOCALE"). That macro no longer appears anywhere under include/, so since then the target has compiled src/format.cc with locale support enabled. It is not a dead target: the pedantic CI jobs build it (linux.yml, macos.yml both pass -DFMT_PEDANTIC=ON), and it passes. So the configuration looks covered while nothing actually tests it. #4627 - a locale-off build break - landed during that window. Define FMT_USE_LOCALE=0 instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- test/CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 0ac690f5..48c5f93a 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -132,8 +132,7 @@ if (FMT_PEDANTIC) add_library(nolocale-test ../src/format.cc) target_include_directories(nolocale-test PRIVATE ${PROJECT_SOURCE_DIR}/include) - target_compile_definitions(nolocale-test - PRIVATE FMT_STATIC_THOUSANDS_SEPARATOR=1) + target_compile_definitions(nolocale-test PRIVATE FMT_USE_LOCALE=0) target_compile_options(nolocale-test PRIVATE $<$:/utf-8>) endif ()