coffee/fmt
1
0
Fork 0
mirror of https://github.com/fmtlib/fmt.git synced 2026-06-15 08:26:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use logical operators for bool checks

Browse Source 
These floating-point formatting checks combine bool values, but they use bitwise '&' and '|' operators. CodeQL flags the expression that applies '!' next to bitwise '&' as incorrect not-operator usage. Use logical '&&' and '||' for the related bool checks so the code expresses boolean logic directly while preserving the same truth table.
This commit is contained in:
Piotr Kiełkowicz 2026-06-09 11:50:22 +02:00
parent 1ccba0cf80
commit f7ed8d643f
No known key found for this signature in database
GPG Key ID: 34CC204F40837136
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/fmt/format-inl.h
View File

@ -1338,7 +1338,7 @@ template <typename T> auto to_decimal(T x) noexcept -> decimal_fp<T> {
if (r < deltai) {
// Exclude the right endpoint if necessary.
if (r == 0 && (z_mul.is_integer & !include_right_endpoint)) {
if (r == 0 && (z_mul.is_integer && !include_right_endpoint)) {
--ret_value.significand;
r = float_info<T>::big_divisor;
goto small_divisor_case_label;
@ -1350,7 +1350,7 @@ template <typename T> auto to_decimal(T x) noexcept -> decimal_fp<T> {
const typename cache_accessor<T>::compute_mul_parity_result x_mul =
cache_accessor<T>::compute_mul_parity(two_fc - 1, cache, beta);
if (!(x_mul.parity | (x_mul.is_integer & include_left_endpoint)))
if (!(x_mul.parity || (x_mul.is_integer && include_left_endpoint)))
goto small_divisor_case_label;
}
ret_value.exponent = minus_k + float_info<T>::kappa + 1;
@ -1390,7 +1390,7 @@ small_divisor_case_label:
// or equivalently, when y is an integer.
if (y_mul.parity != approx_y_parity)
--ret_value.significand;
else if (y_mul.is_integer & (ret_value.significand % 2 != 0))
else if (y_mul.is_integer && (ret_value.significand % 2 != 0))
--ret_value.significand;
return ret_value;
}