From ffd8397db10ceb6e8d663097c647ad8fae71a93f Mon Sep 17 00:00:00 2001 From: Ferdinand Bachmann Date: Fri, 5 Jun 2026 15:40:30 +0200 Subject: [PATCH] Add `fmt_print` to C API (#4789) * Add FMT_FORMAT_ARGS(fmt, ...) macro to C API to simplify user-defined format wrappers * Add fmt_print to C API --- include/fmt/fmt-c.h | 19 ++++++++++++++----- src/fmt-c.cc | 34 +++++++++++++++++++++++++++++----- 2 files changed, 43 insertions(+), 10 deletions(-) diff --git a/include/fmt/fmt-c.h b/include/fmt/fmt-c.h index 20d163a7..e918e77c 100644 --- a/include/fmt/fmt-c.h +++ b/include/fmt/fmt-c.h @@ -10,6 +10,7 @@ #include // bool #include // size_t +#include // FILE #ifdef __cplusplus extern "C" { @@ -46,6 +47,8 @@ enum { fmt_error = -1, fmt_error_invalid_arg = -2 }; int fmt_vformat(char* buffer, size_t size, const char* fmt, const fmt_arg* args, size_t num_args); +int fmt_vprint(FILE* stream, const char* fmt, const fmt_arg* args, + size_t num_args); #ifdef __cplusplus } @@ -181,11 +184,17 @@ typedef enum {} fmt_signed_char; (fmt_arg[]) { FMT_MAP(FMT_MAKE_ARG, ##__VA_ARGS__) } # define FMT_EXPAND(v) v -# define fmt_format(buffer, size, fmt, ...) \ - fmt_vformat((buffer), (size), (fmt), \ - FMT_EXPAND(FMT_VA_SELECT(FMT_MAKE_NULL, FMT_MAKE_ARGLIST, \ - ##__VA_ARGS__)(__VA_ARGS__)), \ - FMT_NARG(, ##__VA_ARGS__)) +# define FMT_FORMAT_ARGS(fmt, ...) \ + (fmt), \ + FMT_EXPAND(FMT_VA_SELECT(FMT_MAKE_NULL, FMT_MAKE_ARGLIST, \ + ##__VA_ARGS__)(__VA_ARGS__)), \ + FMT_NARG(, ##__VA_ARGS__) + +# define fmt_format(buffer, size, fmt, ...) \ + fmt_vformat((buffer), (size), FMT_FORMAT_ARGS((fmt), ##__VA_ARGS__)) + +# define fmt_print(stream, fmt, ...) \ + fmt_vprint((stream), FMT_FORMAT_ARGS((fmt), ##__VA_ARGS__)) #endif // __cplusplus diff --git a/src/fmt-c.cc b/src/fmt-c.cc index 86de48e9..be1e5278 100644 --- a/src/fmt-c.cc +++ b/src/fmt-c.cc @@ -9,12 +9,12 @@ #include -extern "C" int fmt_vformat(char* buffer, size_t size, const char* fmt, - const fmt_arg* args, size_t num_args) { - constexpr size_t max_args = 16; - if (num_args > max_args) return fmt_error_invalid_arg; +constexpr size_t max_c_format_args = 16; +static int convert_c_format_args( + fmt::basic_format_arg* format_args, + const fmt_arg* args, size_t num_args) { + if (num_args > max_c_format_args) return fmt_error_invalid_arg; - fmt::basic_format_arg format_args[max_args]; for (size_t i = 0; i < num_args; ++i) { switch (args[i].type) { case fmt_int: format_args[i] = args[i].value.int_value; break; @@ -31,6 +31,15 @@ extern "C" int fmt_vformat(char* buffer, size_t size, const char* fmt, default: return fmt_error_invalid_arg; } } + return 0; +} + +extern "C" int fmt_vformat(char* buffer, size_t size, const char* fmt, + const fmt_arg* args, size_t num_args) { + fmt::basic_format_arg format_args[max_c_format_args]; + int error = convert_c_format_args(format_args, args, num_args); + if (error != 0) return error; + FMT_TRY { auto result = fmt::vformat_to_n( buffer, size, fmt, @@ -40,3 +49,18 @@ extern "C" int fmt_vformat(char* buffer, size_t size, const char* fmt, FMT_CATCH(...) {} return fmt_error; } + +extern "C" int fmt_vprint(FILE* stream, const char* fmt, const fmt_arg* args, + size_t num_args) { + fmt::basic_format_arg format_args[max_c_format_args]; + int error = convert_c_format_args(format_args, args, num_args); + if (error != 0) return error; + + FMT_TRY { + fmt::vprint(stream, fmt, + fmt::format_args(format_args, static_cast(num_args))); + return 0; + } + FMT_CATCH(...) {} + return fmt_error; +}