Update spelling of Mutex::lock and Mutex::unlock for compatibility

with the standard and the latest Abseil

PiperOrigin-RevId: 806260850
Change-Id: Ie973be4a3aaf7e174cd692ce6df7a82c8f261bf7
This commit is contained in:
Derek Mauro 2025-09-12 06:16:55 -07:00 committed by Copybara-Service
parent 7917641ff9
commit 9df216cc9d
5 changed files with 18 additions and 18 deletions

View File

@ -1530,7 +1530,7 @@ class FunctionMocker<R(Args...)> final : public UntypedFunctionMockerBase {
UntypedOnCallSpecs specs_to_delete; UntypedOnCallSpecs specs_to_delete;
untyped_on_call_specs_.swap(specs_to_delete); untyped_on_call_specs_.swap(specs_to_delete);
g_gmock_mutex.Unlock(); g_gmock_mutex.unlock();
for (UntypedOnCallSpecs::const_iterator it = specs_to_delete.begin(); for (UntypedOnCallSpecs::const_iterator it = specs_to_delete.begin();
it != specs_to_delete.end(); ++it) { it != specs_to_delete.end(); ++it) {
delete static_cast<const OnCallSpec<F>*>(*it); delete static_cast<const OnCallSpec<F>*>(*it);
@ -1538,7 +1538,7 @@ class FunctionMocker<R(Args...)> final : public UntypedFunctionMockerBase {
// Lock the mutex again, since the caller expects it to be locked when we // Lock the mutex again, since the caller expects it to be locked when we
// return. // return.
g_gmock_mutex.Lock(); g_gmock_mutex.lock();
} }
// Returns the result of invoking this mock function with the given // Returns the result of invoking this mock function with the given

View File

@ -436,9 +436,9 @@ bool UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked()
UntypedExpectations expectations_to_delete; UntypedExpectations expectations_to_delete;
untyped_expectations_.swap(expectations_to_delete); untyped_expectations_.swap(expectations_to_delete);
g_gmock_mutex.Unlock(); g_gmock_mutex.unlock();
expectations_to_delete.clear(); expectations_to_delete.clear();
g_gmock_mutex.Lock(); g_gmock_mutex.lock();
return expectations_met; return expectations_met;
} }

View File

@ -1385,9 +1385,9 @@ class GTEST_API_ Mutex {
Mutex(); Mutex();
~Mutex(); ~Mutex();
void Lock(); void lock();
void Unlock(); void unlock();
// Does nothing if the current thread holds the mutex. Otherwise, crashes // Does nothing if the current thread holds the mutex. Otherwise, crashes
// with high probability. // with high probability.
@ -1424,9 +1424,9 @@ class GTEST_API_ Mutex {
// "MutexLock l(&mu)". Hence the typedef trick below. // "MutexLock l(&mu)". Hence the typedef trick below.
class GTestMutexLock { class GTestMutexLock {
public: public:
explicit GTestMutexLock(Mutex* mutex) : mutex_(mutex) { mutex_->Lock(); } explicit GTestMutexLock(Mutex* mutex) : mutex_(mutex) { mutex_->lock(); }
~GTestMutexLock() { mutex_->Unlock(); } ~GTestMutexLock() { mutex_->unlock(); }
private: private:
Mutex* const mutex_; Mutex* const mutex_;
@ -1641,14 +1641,14 @@ class ThreadLocal : public ThreadLocalBase {
class MutexBase { class MutexBase {
public: public:
// Acquires this mutex. // Acquires this mutex.
void Lock() { void lock() {
GTEST_CHECK_POSIX_SUCCESS_(pthread_mutex_lock(&mutex_)); GTEST_CHECK_POSIX_SUCCESS_(pthread_mutex_lock(&mutex_));
owner_ = pthread_self(); owner_ = pthread_self();
has_owner_ = true; has_owner_ = true;
} }
// Releases this mutex. // Releases this mutex.
void Unlock() { void unlock() {
// Since the lock is being released the owner_ field should no longer be // Since the lock is being released the owner_ field should no longer be
// considered valid. We don't protect writing to has_owner_ here, as it's // considered valid. We don't protect writing to has_owner_ here, as it's
// the caller's responsibility to ensure that the current thread holds the // the caller's responsibility to ensure that the current thread holds the
@ -1716,9 +1716,9 @@ class Mutex : public MutexBase {
// "MutexLock l(&mu)". Hence the typedef trick below. // "MutexLock l(&mu)". Hence the typedef trick below.
class GTestMutexLock { class GTestMutexLock {
public: public:
explicit GTestMutexLock(MutexBase* mutex) : mutex_(mutex) { mutex_->Lock(); } explicit GTestMutexLock(MutexBase* mutex) : mutex_(mutex) { mutex_->lock(); }
~GTestMutexLock() { mutex_->Unlock(); } ~GTestMutexLock() { mutex_->unlock(); }
private: private:
MutexBase* const mutex_; MutexBase* const mutex_;
@ -1864,8 +1864,8 @@ class GTEST_API_ ThreadLocal {
class Mutex { class Mutex {
public: public:
Mutex() {} Mutex() {}
void Lock() {} void lock() {}
void Unlock() {} void unlock() {}
void AssertHeld() const {} void AssertHeld() const {}
}; };

View File

@ -320,13 +320,13 @@ Mutex::~Mutex() {
} }
} }
void Mutex::Lock() { void Mutex::lock() {
ThreadSafeLazyInit(); ThreadSafeLazyInit();
::EnterCriticalSection(critical_section_); ::EnterCriticalSection(critical_section_);
owner_thread_id_ = ::GetCurrentThreadId(); owner_thread_id_ = ::GetCurrentThreadId();
} }
void Mutex::Unlock() { void Mutex::unlock() {
ThreadSafeLazyInit(); ThreadSafeLazyInit();
// We don't protect writing to owner_thread_id_ here, as it's the // We don't protect writing to owner_thread_id_ here, as it's the
// caller's responsibility to ensure that the current thread holds the // caller's responsibility to ensure that the current thread holds the

View File

@ -288,8 +288,8 @@ TEST(FormatCompilerIndependentFileLocationTest, FormatsUknownFileAndLine) {
defined(GTEST_OS_OPENBSD) || defined(GTEST_OS_GNU_HURD) defined(GTEST_OS_OPENBSD) || defined(GTEST_OS_GNU_HURD)
void* ThreadFunc(void* data) { void* ThreadFunc(void* data) {
internal::Mutex* mutex = static_cast<internal::Mutex*>(data); internal::Mutex* mutex = static_cast<internal::Mutex*>(data);
mutex->Lock(); mutex->lock();
mutex->Unlock(); mutex->unlock();
return nullptr; return nullptr;
} }