coffee/googletest
1
0
Fork 0
mirror of https://github.com/google/googletest.git synced 2026-06-26 20:38:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update doc for Optional.

Browse Source 
Change a mention of Eq(Optional(nullopt)) to Optional(Eq(nullopt)).

Optional is supposed to wrap matchers, not values. For example, Optional("bla") doesn't compile but Optional(std::string("bla")) does. Optional(Eq("bla")) is the functionally correct version. Eq() cannot wrap a matcher.

PiperOrigin-RevId: 872885639
Change-Id: I941f515308fa419162998073f6da9731fcf2168a
This commit is contained in:
Abseil Team 2026-02-20 07:09:50 -08:00 committed by Copybara-Service
parent 850cb69efd
commit e9907112b4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
googlemock/include/gmock/gmock-matchers.h
View File

@ -5548,7 +5548,7 @@ inline InnerMatcher AllArgs(const InnerMatcher& matcher) {
// printable using 'PrintToString'. It is compatible with
// std::optional/std::experimental::optional.
// Note that to compare an optional type variable against nullopt you should
// use Eq(nullopt) and not Eq(Optional(nullopt)). The latter implies that the
// use Eq(nullopt) and not Optional(Eq(nullopt)). The latter implies that the
// optional value contains an optional itself.
template <typename ValueMatcher>
inline internal::OptionalMatcher<ValueMatcher> Optional(