mirror of
https://github.com/google/googletest.git
synced 2026-06-16 00:46:08 +08:00
b7ced159db
Both OnceAction compatibility traits, IsDirectlyCompatible and
IsCompatibleAfterIgnoringArguments, check std::is_constructible before
is_callable_r.
On libc++ that order breaks. Evaluating
is_constructible<std::tuple<OnceAction&&>, ...> drives libc++'s tuple
constructor SFINAE, which calls back into OnceAction's converting
constructor and re-enters the conjunction while it is still incomplete.
GCC <= 8 (e.g. QNX 7.1's gcc 8.3) rejects this with:
incomplete type ... used in nested name specifier
so EXPECT_CALL(m, f()).WillOnce(Return(...)) fails to compile. GCC >= 9
and every Clang accept the original order; libstdc++ is unaffected.
Swapping the two checks fixes it: is_callable_r is cheap and
non-recursive, so the conjunction short-circuits to false for the
non-callable tuple before is_constructible is instantiated.
Fixes #3947.
|
||
|---|---|---|
| .. | ||
| internal | ||
| gmock-actions.h | ||
| gmock-cardinalities.h | ||
| gmock-function-mocker.h | ||
| gmock-matchers.h | ||
| gmock-more-actions.h | ||
| gmock-more-matchers.h | ||
| gmock-nice-strict.h | ||
| gmock-spec-builders.h | ||
| gmock.h | ||