diff --git a/407f21fe2985bc4a7a0c746e4e411bfe3a16af46 b/407f21fe2985bc4a7a0c746e4e411bfe3a16af46 index 1b316d989..7b5e78b4b 100644 --- a/407f21fe2985bc4a7a0c746e4e411bfe3a16af46 +++ b/407f21fe2985bc4a7a0c746e4e411bfe3a16af46 @@ -34,6 +34,24 @@ "revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, + { + "unresolved": false, + "key": { + "uuid": "49622805_8d3cd182", + "filename": "include/libyuv/scale_row.h", + "patchSetId": 2 + }, + "lineNbr": 200, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-27T21:35:13Z", + "side": 1, + "message": "Done. I moved the overflow checks to the callers. Note that the overflow checks are not obvious when they are performned by the callers because the operation that could overflow isn\u0027t there.", + "parentUuid": "67be1114_3bb92ffb", + "revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, { "unresolved": true, "key": { @@ -69,6 +87,24 @@ "revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, + { + "unresolved": false, + "key": { + "uuid": "68892df7_6a53e8b6", + "filename": "source/convert.cc", + "patchSetId": 2 + }, + "lineNbr": 297, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-27T21:35:13Z", + "side": 1, + "message": "Thank you for the analysis. In `FixedDiv(height, uv_height)`, we have `num\u003dheight` and `div\u003duv_height`. So the quotient is \u003c\u003d 2 and won\u0027t overflow.", + "parentUuid": "493e92b1_e844beab", + "revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, { "unresolved": true, "key": { @@ -86,6 +122,24 @@ "revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, + { + "unresolved": false, + "key": { + "uuid": "5090ebc4_bafbc4d5", + "filename": "source/convert.cc", + "patchSetId": 2 + }, + "lineNbr": 302, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-27T21:35:13Z", + "side": 1, + "message": "Done. Changed the return type of `ScalePlaneVertical_16To8()` back to `void`.", + "parentUuid": "b87b7250_b3590de7", + "revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, { "unresolved": false, "key": { diff --git a/4a636caa076c10b7aec2fa749e7589394d44d74f b/4a636caa076c10b7aec2fa749e7589394d44d74f new file mode 100644 index 000000000..66fe17288 --- /dev/null +++ b/4a636caa076c10b7aec2fa749e7589394d44d74f @@ -0,0 +1,38 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "87917200_e9264452", + "filename": "source/scale.cc", + "patchSetId": 3 + }, + "lineNbr": 2100, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-27T21:35:13Z", + "side": 1, + "message": "I corrected the parameter name in the comment. The parameter is named `wpp`, not `bpp`.", + "revId": "4a636caa076c10b7aec2fa749e7589394d44d74f", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": false, + "key": { + "uuid": "458bb52f_b320e91e", + "filename": "source/scale_argb.cc", + "patchSetId": 3 + }, + "lineNbr": 751, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-27T21:35:13Z", + "side": 1, + "message": "The `ScalePlaneVertical()` call performs the multiplication `clip_width * 4` using the `int` type. This detects overflow in that multiplication.\n\nNote that the reason for the `clip_width \u003e INT_MAX / 4` check is not obvious when it is performed by the caller.", + "revId": "4a636caa076c10b7aec2fa749e7589394d44d74f", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + } + ] +} \ No newline at end of file