Add config validation PRESUBMIT.py, and fix validation errors

TBR:fbarchard
Bug: 868176
Change-Id: Ibb2628cac8b26dc9771fc9bab6c00889d6d906eb
Reviewed-on: https://chromium-review.googlesource.com/1153647
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
This commit is contained in:
Ryan Tseng 2018-07-27 13:51:38 -07:00 committed by Commit Bot
parent 574b156e3a
commit 2c8f5fe35a
3 changed files with 15 additions and 4 deletions

11
PRESUBMIT.py Normal file
View File

@ -0,0 +1,11 @@
# Copyright 2018 The PDFium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
def CheckChangeOnUpload(input_api, output_api):
return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api)

View File

@ -59,9 +59,9 @@ acl_sets {
} }
} }
bucket { buckets {
name: "luci.libyuv.ci" name: "luci.libyuv.ci"
acl_sets: "ci acl_sets: "ci"
swarming { swarming {
hostname: "chromium-swarm.appspot.com" hostname: "chromium-swarm.appspot.com"
builder_defaults { builder_defaults {
@ -219,7 +219,7 @@ bucket {
} }
} }
bucket { buckets {
name: "luci.libyuv.try" name: "luci.libyuv.try"
acl_sets: "try" acl_sets: "try"
swarming { swarming {

View File

@ -179,7 +179,7 @@ consoles {
repo_url: "https://chromium.googlesource.com/libyuv/libyuv/" repo_url: "https://chromium.googlesource.com/libyuv/libyuv/"
refs: "refs/heads/master" refs: "refs/heads/master"
manifest_name: "REVISION" manifest_name: "REVISION"
builder_view_only: builder_view_only: true
builders { builders {
name: "buildbucket/luci.libyuv.ci/android" name: "buildbucket/luci.libyuv.ci/android"