From 3429519bd1d4e2df6484b88ac9887982f687ee31 Mon Sep 17 00:00:00 2001
From: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Date: Mon, 27 Jul 2026 16:31:11 -0700
Subject: [PATCH] Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
---
 4a636caa076c10b7aec2fa749e7589394d44d74f | 34 ++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/4a636caa076c10b7aec2fa749e7589394d44d74f b/4a636caa076c10b7aec2fa749e7589394d44d74f
index 66fe17288..6be8cf049 100644
--- a/4a636caa076c10b7aec2fa749e7589394d44d74f
+++ b/4a636caa076c10b7aec2fa749e7589394d44d74f
@@ -33,6 +33,40 @@
       "message": "The `ScalePlaneVertical()` call performs the multiplication `clip_width * 4` using the `int` type. This detects overflow in that multiplication.\n\nNote that the reason for the `clip_width \u003e INT_MAX / 4` check is not obvious when it is performed by the caller.",
       "revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
       "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d638e918_eeac63d0",
+        "filename": "source/scale_common.cc",
+        "patchSetId": 3
+      },
+      "lineNbr": 1632,
+      "author": {
+        "id": 1115898
+      },
+      "writtenOn": "2026-07-27T23:31:11Z",
+      "side": 1,
+      "message": "this doesnt seem right?  the intent was 16.16 maximum is 32767.  using int64 to represent int16 is overkill and implies 64 bit size support.\nvalues are kept signed for overflow safety and to allow mirroring",
+      "revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "84dc2118_4c61a116",
+        "filename": "unit_test/convert_test.cc",
+        "patchSetId": 3
+      },
+      "lineNbr": 2601,
+      "author": {
+        "id": 1115898
+      },
+      "writtenOn": "2026-07-27T23:31:11Z",
+      "side": 1,
+      "message": "40000 is beyond what 16.16 can index.  can we gracefully fail (-1)",
+      "revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
     }
   ]
 }
\ No newline at end of file