From 36bb2c2b14676d97c0dfbef49e1922ecddb096fc Mon Sep 17 00:00:00 2001 From: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Thu, 12 Dec 2024 01:33:50 -0800 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"} --- b119232c3dcd49bc54f76c732ec21d0ed60617bc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/b119232c3dcd49bc54f76c732ec21d0ed60617bc b/b119232c3dcd49bc54f76c732ec21d0ed60617bc index 304072ee2..7c9b18e02 100644 --- a/b119232c3dcd49bc54f76c732ec21d0ed60617bc +++ b/b119232c3dcd49bc54f76c732ec21d0ed60617bc @@ -16,6 +16,23 @@ "message": "(this needs all of the earlier commits in the chain to be committed first)", "revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": false, + "key": { + "uuid": "b26ed1c6_e79a978d", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 1115898 + }, + "writtenOn": "2024-12-12T09:33:50Z", + "side": 1, + "message": "theres pros and cons to this approach, but the end result is roughly 4x less code, so thats a win.\nIts a little hard to see how the macros piece together into a row function because they are far away from the wrapper. If each macro is basically only used once, it may be easier to understand it if its just above the function?", + "revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file