From 4299cc9a3dea67add8bca07af9f3fe07c90e3f43 Mon Sep 17 00:00:00 2001 From: Gerrit User 3668288 <3668288@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Mon, 13 Jan 2025 08:15:42 -0800 Subject: [PATCH] Update patch set 3 Patch Set 3: (1 comment) Patch-set: 3 Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_3668288\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_3668288\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 3668288 \u003c3668288@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_3668288\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1001629 \u003c1001629@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_3668288\u003e replied on the change"} --- 298bd480ba48b445d8c185b4a660be96256f4b4a | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/298bd480ba48b445d8c185b4a660be96256f4b4a b/298bd480ba48b445d8c185b4a660be96256f4b4a index 22f84e388..10b6d0178 100644 --- a/298bd480ba48b445d8c185b4a660be96256f4b4a +++ b/298bd480ba48b445d8c185b4a660be96256f4b4a @@ -280,6 +280,24 @@ "parentUuid": "95e580ce_76f88f82", "revId": "298bd480ba48b445d8c185b4a660be96256f4b4a", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": true, + "key": { + "uuid": "9cffcedb_d1803a26", + "filename": "BUILD.gn", + "patchSetId": 2 + }, + "lineNbr": 259, + "author": { + "id": 3668288 + }, + "writtenOn": "2025-01-13T16:15:42Z", + "side": 1, + "message": "I\u0027ve opted in to using pragma directives for pushing and popping the required attributes for each file respectively. \nThis seemed like the most convenient solution and is also possible to do in clang/gcc. Would like to know your input.", + "parentUuid": "f538ab58_b062bd5d", + "revId": "298bd480ba48b445d8c185b4a660be96256f4b4a", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file