From 4f4e1ac553d07dd27a925e46d5e4e77d8b1236d4 Mon Sep 17 00:00:00 2001 From: Frank Barchard Date: Thu, 9 Apr 2026 11:03:54 -0700 Subject: [PATCH] Fix 2 failing golden tests - Add ifdef for LIBYUV_UNLIMITED_DATA Fixed by Gemini just telling it how to build and run the test and to fix it. Bug: libyuv:353545922 Change-Id: I117a25b75b9616ee2ce6122aa163c2085ed4dc7d Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7742120 Reviewed-by: James Zern Commit-Queue: Frank Barchard --- README.chromium | 2 +- include/libyuv/version.h | 2 +- unit_test/convert_argb_test.cc | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/README.chromium b/README.chromium index 698e99b24..fb002240e 100644 --- a/README.chromium +++ b/README.chromium @@ -1,6 +1,6 @@ Name: libyuv URL: https://chromium.googlesource.com/libyuv/libyuv/ -Version: 1923 +Version: 1924 Revision: DEPS License: BSD-3-Clause License File: LICENSE diff --git a/include/libyuv/version.h b/include/libyuv/version.h index c132cdafb..039324bdd 100644 --- a/include/libyuv/version.h +++ b/include/libyuv/version.h @@ -11,6 +11,6 @@ #ifndef INCLUDE_LIBYUV_VERSION_H_ #define INCLUDE_LIBYUV_VERSION_H_ -#define LIBYUV_VERSION 1923 +#define LIBYUV_VERSION 1924 #endif // INCLUDE_LIBYUV_VERSION_H_ diff --git a/unit_test/convert_argb_test.cc b/unit_test/convert_argb_test.cc index 00ec67fae..c272f13c0 100644 --- a/unit_test/convert_argb_test.cc +++ b/unit_test/convert_argb_test.cc @@ -2704,7 +2704,11 @@ TEST_F(LibYUVConvertTest, TestYUY2ToARGB) { } YUY2ToARGB(&orig_pixels[0][0], 0, &dest_argb[0][0], 0, 256, 1); uint32_t checksum = HashDjb2(&dest_argb[0][0], sizeof(dest_argb), 5381); +#if defined(LIBYUV_UNLIMITED_DATA) + EXPECT_EQ(10343289u, checksum); +#else EXPECT_EQ(3486643515u, checksum); +#endif } TEST_F(LibYUVConvertTest, TestUYVYToARGB) { @@ -2718,7 +2722,11 @@ TEST_F(LibYUVConvertTest, TestUYVYToARGB) { } UYVYToARGB(&orig_pixels[0][0], 0, &dest_argb[0][0], 0, 256, 1); uint32_t checksum = HashDjb2(&dest_argb[0][0], sizeof(dest_argb), 5381); +#if defined(LIBYUV_UNLIMITED_DATA) + EXPECT_EQ(10343289u, checksum); +#else EXPECT_EQ(3486643515u, checksum); +#endif } #ifdef ENABLE_ROW_TESTS