coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-10-28 18:07:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential int overflows in ScaleFilterReduce()

Browse Source 
Change-Id: I2eb69772f0d65760a87360e46215a6c6d69f250f
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/8170700
Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
This commit is contained in:
Wan-Teh Chang 2026-08-25 18:52:39 -07:00 committed by libyuv-scoped@luci-project-accounts.iam.gserviceaccount.com
parent 3793561ddc
commit 50031d294e
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/scale_common.cc
View File

@ -1642,7 +1642,8 @@ enum FilterMode ScaleFilterReduce(int src_width,
}
if (filtering == kFilterBox) {
// If scaling either axis to 0.5 or larger, switch from Box to Bilinear.
if (dst_width * 2 >= src_width || dst_height * 2 >= src_height) {
if ((int64_t)dst_width * 2 >= src_width ||
(int64_t)dst_height * 2 >= src_height) {
filtering = kFilterBilinear;
}
}
@ -1651,7 +1652,7 @@ enum FilterMode ScaleFilterReduce(int src_width,
filtering = kFilterLinear;
}
// TODO(fbarchard): Detect any odd scale factor and reduce to Linear.
if (dst_height == src_height || dst_height * 3 == src_height) {
if (dst_height == src_height || (int64_t)dst_height * 3 == src_height) {
filtering = kFilterLinear;
}
// TODO(fbarchard): Remove 1 pixel wide filter restriction, which is to
@ -1665,7 +1666,7 @@ enum FilterMode ScaleFilterReduce(int src_width,
filtering = kFilterNone;
}
// TODO(fbarchard): Detect any odd scale factor and reduce to None.
if (dst_width == src_width || dst_width * 3 == src_width) {
if (dst_width == src_width || (int64_t)dst_width * 3 == src_width) {
filtering = kFilterNone;
}
}