From 502febe8f206e724e41be0581b84844d3e7e0964 Mon Sep 17 00:00:00 2001
From: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Date: Thu, 4 Jun 2026 18:13:18 -0700
Subject: [PATCH] Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
---
 b7c959cab59f863d787b3c683dcfb4b427cd2a56 | 21 +++++++++++++++++++++
 d9cdb6f3a52d12d9aff43903bd7c3e9bf74a798b | 21 +++++++++++++++++++++
 2 files changed, 42 insertions(+)
 create mode 100644 b7c959cab59f863d787b3c683dcfb4b427cd2a56
 create mode 100644 d9cdb6f3a52d12d9aff43903bd7c3e9bf74a798b

diff --git a/b7c959cab59f863d787b3c683dcfb4b427cd2a56 b/b7c959cab59f863d787b3c683dcfb4b427cd2a56
new file mode 100644
index 000000000..ada5da4f4
--- /dev/null
+++ b/b7c959cab59f863d787b3c683dcfb4b427cd2a56
@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "7dbbafcc_a36118d0",
+        "filename": "source/convert.cc",
+        "patchSetId": 3
+      },
+      "lineNbr": 187,
+      "author": {
+        "id": 1115898
+      },
+      "writtenOn": "2026-06-05T01:13:18Z",
+      "side": 0,
+      "message": "note that this breaks c89 compatability.  which i think is fine.\nbut if we did want to declare variables after there are 2 ways\n\n  int uv_width;\n  int uv_height;\n  int scale;\n\n  if ((!src_y \u0026\u0026 dst_y) || !src_u || !src_v || !dst_u || !dst_v || width \u003c\u003d 0 ||\n      height \u003d\u003d 0 || height \u003d\u003d INT_MIN) {\n    return -1;\n  }\n\n  uv_width \u003d SUBSAMPLE(width, subsample_x, subsample_x);\n  uv_height \u003d SUBSAMPLE(height, subsample_y, subsample_y);\n  scale \u003d 1 \u003c\u003c (24 - depth);\n\nor with scoping\n\n\n  if ((!src_y \u0026\u0026 dst_y) || !src_u || !src_v || !dst_u || !dst_v || width \u003c\u003d 0 ||\n      height \u003d\u003d 0 || height \u003d\u003d INT_MIN) {\n    return -1;\n  }\n  {\n    int uv_width \u003d SUBSAMPLE(width, subsample_x, subsample_x);\n    int uv_height \u003d SUBSAMPLE(height, subsample_y, subsample_y);\n    int scale \u003d 1 \u003c\u003c (24 - depth);\n...\n  }\n\nsome other projects are adopting c11 which has compile time assert and alignment related support.\n\nunrelated i was just asked about fp16 and that would be C23 that adds _Float16 and a ton of other things... basically everything C++ can do, except classes.\nnotable would be templates and overloads.\nif/when we need better fp16 support it may be worth consideration.",
+      "revId": "b7c959cab59f863d787b3c683dcfb4b427cd2a56",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    }
+  ]
+}
\ No newline at end of file
diff --git a/d9cdb6f3a52d12d9aff43903bd7c3e9bf74a798b b/d9cdb6f3a52d12d9aff43903bd7c3e9bf74a798b
new file mode 100644
index 000000000..02ae6f88d
--- /dev/null
+++ b/d9cdb6f3a52d12d9aff43903bd7c3e9bf74a798b
@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "241812d0_58c6164c",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1115898
+      },
+      "writtenOn": "2026-06-05T01:13:18Z",
+      "side": 1,
+      "message": "virtually all functions support negative height and will have height \u003d -height\n\nbut in practice a height of 2 billion is likely problematic for other reasons, especially on 32 bit cpus",
+      "revId": "d9cdb6f3a52d12d9aff43903bd7c3e9bf74a798b",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    }
+  ]
+}
\ No newline at end of file