From 51e1cea95d455adfcf4eaaa57d52f005767d6774 Mon Sep 17 00:00:00 2001 From: Gerrit User 1366072 <1366072@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Thu, 28 Nov 2024 07:26:16 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: (1 comment) Patch-set: 3 Attention: {"person_ident":"Gerrit User 1178490 \u003c1178490@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1366072\u003e mentioned you in a comment"} --- b8e1539ce0471f6758709597f18e10c63907680e | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/b8e1539ce0471f6758709597f18e10c63907680e b/b8e1539ce0471f6758709597f18e10c63907680e index 831c79dbf..9efc5894d 100644 --- a/b8e1539ce0471f6758709597f18e10c63907680e +++ b/b8e1539ce0471f6758709597f18e10c63907680e @@ -63,6 +63,30 @@ }, "revId": "b8e1539ce0471f6758709597f18e10c63907680e", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": true, + "key": { + "uuid": "f452f768_d4d653a7", + "filename": "DEPS", + "patchSetId": 3 + }, + "lineNbr": 18, + "author": { + "id": 1366072 + }, + "writtenOn": "2024-11-28T07:26:16Z", + "side": 1, + "message": "\u003e Also, was this copied from https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/DEPS;l\u003d46;drc\u003daaaeb29ef54828cce3f6aab4d718487640235ab5 (in such case, why rbe-webrtc-untrusted instead of rbe-webrtc-developer?).\n\n@mbonadei@chromium.org is correct.\nChrome developers uses`rbe-chrome-untrusted`, while WebRTC developers use `rbe-webrtc-developer`. There is some context in go/webtc-rbe-instances.\n\nSo this should be `rbe-webrtc-developer`, I think.", + "parentUuid": "a7044694_e422846f", + "range": { + "startLine": 18, + "startChar": 32, + "endLine": 18, + "endChar": 52 + }, + "revId": "b8e1539ce0471f6758709597f18e10c63907680e", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file