diff --git a/include/libyuv/row.h b/include/libyuv/row.h index 045160c1d..994df06e1 100644 --- a/include/libyuv/row.h +++ b/include/libyuv/row.h @@ -105,17 +105,6 @@ extern "C" { #define HAS_COPYROW_SSE2 #define HAS_H422TOARGBROW_SSSE3 #define HAS_I400TOARGBROW_SSE2 -// The following functions fail on gcc/clang 32 bit with fpic and framepointer. -// caveat: clangcl uses row_win.cc which works. -#if defined(NDEBUG) || !(defined(_DEBUG) && defined(__i386__)) || \ - !defined(__i386__) || defined(_MSC_VER) -// TODO(fbarchard): fix build error on x86 debug -// https://code.google.com/p/libyuv/issues/detail?id=524 -#define HAS_I411TOARGBROW_SSSE3 -// TODO(fbarchard): fix build error on android_full_debug=1 -// https://code.google.com/p/libyuv/issues/detail?id=517 -#define HAS_I422ALPHATOARGBROW_SSSE3 -#endif #define HAS_I422TOARGB1555ROW_SSSE3 #define HAS_I422TOARGB4444ROW_SSSE3 #define HAS_I422TOARGBROW_SSSE3 @@ -130,7 +119,6 @@ extern "C" { #define HAS_MERGEUVROW_SSE2 #define HAS_MIRRORROW_SSSE3 #define HAS_MIRRORUVROW_SSSE3 -#define HAS_MIRRORUVROW_SSSE3 #define HAS_NV12TOARGBROW_SSSE3 #define HAS_NV12TORGB565ROW_SSSE3 #define HAS_NV21TOARGBROW_SSSE3 @@ -173,6 +161,7 @@ extern "C" { #define HAS_ARGBSHADEROW_SSE2 #define HAS_ARGBSUBTRACTROW_SSE2 #define HAS_ARGBUNATTENUATEROW_SSE2 +#define HAS_BLENDPLANEROW_SSSE3 #define HAS_COMPUTECUMULATIVESUMROW_SSE2 #define HAS_CUMULATIVESUMTOAVERAGEROW_SSE2 #define HAS_INTERPOLATEROW_SSSE3 @@ -182,7 +171,18 @@ extern "C" { #define HAS_SOBELXROW_SSE2 #define HAS_SOBELXYROW_SSE2 #define HAS_SOBELYROW_SSE2 -#define HAS_BLENDPLANEROW_SSSE3 + +// The following functions fail on gcc/clang 32 bit with fpic and framepointer. +// caveat: clangcl uses row_win.cc which works. +#if defined(NDEBUG) || !(defined(_DEBUG) && defined(__i386__)) || \ + !defined(__i386__) || defined(_MSC_VER) +// TODO(fbarchard): fix build error on x86 debug +// https://code.google.com/p/libyuv/issues/detail?id=524 +#define HAS_I411TOARGBROW_SSSE3 +// TODO(fbarchard): fix build error on android_full_debug=1 +// https://code.google.com/p/libyuv/issues/detail?id=517 +#define HAS_I422ALPHATOARGBROW_SSSE3 +#endif #endif // The following are available on all x86 platforms, but @@ -264,7 +264,6 @@ extern "C" { // The following are available on Neon platforms: #if !defined(LIBYUV_DISABLE_NEON) && \ (defined(__aarch64__) || defined(__ARM_NEON__) || defined(LIBYUV_NEON)) -#define HAS_I422ALPHATOARGBROW_NEON #define HAS_ABGRTOUVROW_NEON #define HAS_ABGRTOYROW_NEON #define HAS_ARGB1555TOARGBROW_NEON @@ -292,6 +291,7 @@ extern "C" { #define HAS_COPYROW_NEON #define HAS_I400TOARGBROW_NEON #define HAS_I411TOARGBROW_NEON +#define HAS_I422ALPHATOARGBROW_NEON #define HAS_I422TOARGB1555ROW_NEON #define HAS_I422TOARGB4444ROW_NEON #define HAS_I422TOARGBROW_NEON diff --git a/unit_test/planar_test.cc b/unit_test/planar_test.cc index a816f4fdd..9146c9a45 100644 --- a/unit_test/planar_test.cc +++ b/unit_test/planar_test.cc @@ -1330,7 +1330,9 @@ TEST_F(LibYUVPlanarTest, I420Blend_Unaligned) { TestI420Blend(benchmark_width_, benchmark_height_, benchmark_iterations_, disable_cpu_flags_, benchmark_cpu_info_, +1, 1); } -TEST_F(LibYUVPlanarTest, I420Blend_Any) { + +// TODO(fbarchard): DISABLED because _Any uses C. Avoid C and re-enable. +TEST_F(LibYUVPlanarTest, DISABLED_I420Blend_Any) { TestI420Blend(benchmark_width_ - 4, benchmark_height_, benchmark_iterations_, disable_cpu_flags_, benchmark_cpu_info_, +1, 0); } diff --git a/unit_test/rotate_test.cc b/unit_test/rotate_test.cc index b7957aa96..1f5b86e95 100644 --- a/unit_test/rotate_test.cc +++ b/unit_test/rotate_test.cc @@ -262,28 +262,28 @@ TEST_F(LibYUVRotateTest, DISABLED_NV12Rotate270_Odd) { disable_cpu_flags_, benchmark_cpu_info_); } -TEST_F(LibYUVRotateTest, NV12Rotate0_Inverted) { +TEST_F(LibYUVRotateTest, NV12Rotate0_Invert) { NV12TestRotate(benchmark_width_, -benchmark_height_, benchmark_width_, benchmark_height_, kRotate0, benchmark_iterations_, disable_cpu_flags_, benchmark_cpu_info_); } -TEST_F(LibYUVRotateTest, NV12Rotate90_Inverted) { +TEST_F(LibYUVRotateTest, NV12Rotate90_Invert) { NV12TestRotate(benchmark_width_, -benchmark_height_, benchmark_height_, benchmark_width_, kRotate90, benchmark_iterations_, disable_cpu_flags_, benchmark_cpu_info_); } -TEST_F(LibYUVRotateTest, NV12Rotate180_Inverted) { +TEST_F(LibYUVRotateTest, NV12Rotate180_Invert) { NV12TestRotate(benchmark_width_, -benchmark_height_, benchmark_width_, benchmark_height_, kRotate180, benchmark_iterations_, disable_cpu_flags_, benchmark_cpu_info_); } -TEST_F(LibYUVRotateTest, NV12Rotate270_Inverted) { +TEST_F(LibYUVRotateTest, NV12Rotate270_Invert) { NV12TestRotate(benchmark_width_, -benchmark_height_, benchmark_height_, benchmark_width_, kRotate270, benchmark_iterations_,