coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2025-12-09 18:26:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 2

Browse Source 
Patch Set 2: Code-Review+1

(3 comments)

Patch-set: 2
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, 9e11e99548d05b62434922cb390c868896cffd80
Attention: {"person_ident":"Gerrit User 3711818 \u003c3711818@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
This commit is contained in:
Gerrit User 1115898 2025-09-29 11:10:16 -07:00 committed by Gerrit Code Review
parent 9309242016
commit 582fe38324
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
3bfe5a2a8404f30b50936da9e1701caaa0c560a0 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "8477c202_3fc526a2",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 9,
"author": {
"id": 1115898
},
"writtenOn": "2025-09-29T18:10:16Z",
"side": 1,
"message": "best to trust but verify. Using a code snippet you can try gcc and clang versions in godbolt. I also ran into bugs with __riscv_v_intrinsic not set correctly.\nMy personal ability to test is with an old clang compiler on emulator, and in future I expect android builds which will come with newer clang versions",
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "48b42b80_9c8ebcf4",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2025-09-29T18:10:16Z",
"side": 1,
"message": "thanks for the update",
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "731fbff1_215d1d0e",
"filename": "include/libyuv/scale_row.h",
"patchSetId": 2
},
"lineNbr": 173,
"author": {
"id": 1115898
},
"writtenOn": "2025-09-29T18:10:16Z",
"side": 1,
"message": "nit For consistency this line would go after line 176 // The following...",
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}