From 6cdbfd178683c09dec9740649a57d701b2b0ef9a Mon Sep 17 00:00:00 2001
From: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Date: Wed, 14 Oct 2026 15:59:39 -0700
Subject: [PATCH] Update patch set 4

Patch Set 4: Code-Review+1

(4 comments)

Patch-set: 4
Reviewer: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, 7ba8167943cf9cdecdadfa46973204fb6e0df931
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
---
 8dabf898eeee2e08d41666ee24533da35f4dcee7 | 72 ++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 8dabf898eeee2e08d41666ee24533da35f4dcee7

diff --git a/8dabf898eeee2e08d41666ee24533da35f4dcee7 b/8dabf898eeee2e08d41666ee24533da35f4dcee7
new file mode 100644
index 000000000..381929448
--- /dev/null
+++ b/8dabf898eeee2e08d41666ee24533da35f4dcee7
@@ -0,0 +1,72 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "ea7b6741_a4828652",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 4
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1001562
+      },
+      "writtenOn": "2026-10-14T22:59:39Z",
+      "side": 1,
+      "message": "LGTM. Thanks for the fix!",
+      "revId": "8dabf898eeee2e08d41666ee24533da35f4dcee7",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "3019a141_74e1382a",
+        "filename": "source/scale.cc",
+        "patchSetId": 4
+      },
+      "lineNbr": 947,
+      "author": {
+        "id": 1001562
+      },
+      "writtenOn": "2026-10-14T22:59:39Z",
+      "side": 1,
+      "message": "Frank: Do you know why `max_y` is defined as `src_height \u003c\u003c 16` in only three places but defined as `(src_height - 1) \u003c\u003c 16` in all other places?",
+      "revId": "8dabf898eeee2e08d41666ee24533da35f4dcee7",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b7ceb797_58aa9f11",
+        "filename": "source/scale.cc",
+        "patchSetId": 4
+      },
+      "lineNbr": 2129,
+      "author": {
+        "id": 1001562
+      },
+      "writtenOn": "2026-10-14T22:59:39Z",
+      "side": 1,
+      "message": "`FixedDiv(src_height, src_height)` is equal to `1 \u003c\u003c 16`, right?\n\nShould we replace this line with the following?\n\n```\n      dy \u003d 1 \u003c\u003c 16;  // 1 as 16.16 fixed point\n```\n\nor\n\n```\n      dy \u003d 1 \u003c\u003c 16;  // FixedDiv(src_height, src_height)\n```",
+      "revId": "8dabf898eeee2e08d41666ee24533da35f4dcee7",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c8c55c35_2a5db94b",
+        "filename": "source/scale.cc",
+        "patchSetId": 4
+      },
+      "lineNbr": 2248,
+      "author": {
+        "id": 1001562
+      },
+      "writtenOn": "2026-10-14T22:59:39Z",
+      "side": 1,
+      "message": "Should we replace this line with the following?\n\n```\n      dy \u003d 1 \u003c\u003c 16;  // 1 as 16.16 fixed point\n```\n\nor\n\n```\n      dy \u003d 1 \u003c\u003c 16;  // FixedDiv(src_height, src_height)\n```",
+      "revId": "8dabf898eeee2e08d41666ee24533da35f4dcee7",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    }
+  ]
+}
\ No newline at end of file