From 6e62ff34957ffe296c111d7658eb13981b85e825 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrik=20H=C3=B6glund?= Date: Fri, 10 Aug 2018 10:17:59 +0200 Subject: [PATCH] Fix missing brace + incorrect nesting in cq.cfg. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit try_job can't be repeated, but buckets can. I think this does what Ryan intended. Also add a presubmit so this doesn't happen again. No-try because CQ is broken, and even if it weren't nothing would catch errors in cq.cfq directly. No-try: True Tbr: fbarchard@chromium.org Bug: 869249 Change-Id: If84685f93275f5af691fc3fef77881156930b726 Reviewed-on: https://chromium-review.googlesource.com/1169820 Commit-Queue: Patrik Höglund Reviewed-by: Patrik Höglund --- infra/config/PRESUBMIT.py | 15 +++++++++++++++ infra/config/cq.cfg | 2 -- 2 files changed, 15 insertions(+), 2 deletions(-) create mode 100644 infra/config/PRESUBMIT.py diff --git a/infra/config/PRESUBMIT.py b/infra/config/PRESUBMIT.py new file mode 100644 index 000000000..89eaa5192 --- /dev/null +++ b/infra/config/PRESUBMIT.py @@ -0,0 +1,15 @@ +# Copyright 2018 The LibYuv Project Authors. All rights reserved. +# +# Use of this source code is governed by a BSD-style license +# that can be found in the LICENSE file in the root of the source +# tree. An additional intellectual property rights grant can be found +# in the file PATENTS. All contributing project authors may +# be found in the AUTHORS file in the root of the source tree. + + +def CheckChangeOnUpload(input_api, output_api): + return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api) + + +def CheckChangeOnCommit(input_api, output_api): + return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api) diff --git a/infra/config/cq.cfg b/infra/config/cq.cfg index e5976c3b2..53bdaf7e8 100644 --- a/infra/config/cq.cfg +++ b/infra/config/cq.cfg @@ -23,8 +23,6 @@ verifiers { builders { name: "win_clang_rel" } builders { name: "win_x64_clang_rel" } } - - try_job { buckets { name: "luci.libyuv.try" builders { name: "win" experiment_percentage: 100 }