From 76491526e315293b3816a0af5af987db3bb6566e Mon Sep 17 00:00:00 2001 From: Gerrit User 4524974 <4524974@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Wed, 10 Dec 2025 00:33:58 -0800 Subject: [PATCH] Update patch set 3 Patch Set 3: (1 comment) Patch-set: 3 Attention: {"person_ident":"Gerrit User 4524974 \u003c4524974@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4524974\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4524974\u003e replied on the change"} --- a47e0c8cf4f28716867fb070146632e6add22c2b | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/a47e0c8cf4f28716867fb070146632e6add22c2b b/a47e0c8cf4f28716867fb070146632e6add22c2b index 04b5650ea..34205b64e 100644 --- a/a47e0c8cf4f28716867fb070146632e6add22c2b +++ b/a47e0c8cf4f28716867fb070146632e6add22c2b @@ -50,6 +50,24 @@ "message": "this is fine but the very last line of these files has a comment defined(__clang__)\ncould you remove those as well?\n\nas far as I know, theres no visual c or other compilers that support rvv, but this will enable all of them.", "revId": "a47e0c8cf4f28716867fb070146632e6add22c2b", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": false, + "key": { + "uuid": "795f8f00_eda31d03", + "filename": "source/row_rvv.cc", + "patchSetId": 2 + }, + "lineNbr": 21, + "author": { + "id": 4524974 + }, + "writtenOn": "2025-12-10T08:33:58Z", + "side": 1, + "message": "Done! I removed those comments. Thanks for pointing it out, don\u0027t know how I missed them.\n\nI don\u0027t think Visual C even supports the RISC-V ISA? Would you prefer it with CLANG *and* GCC guards? I think this should be fine as is, right?", + "parentUuid": "76088842_309ed602", + "revId": "a47e0c8cf4f28716867fb070146632e6add22c2b", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file