From 764d231abf3bfab07e17c7214bf0bb129e7c5af6 Mon Sep 17 00:00:00 2001 From: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Wed, 29 Jul 2026 16:18:27 -0700 Subject: [PATCH] Update patch set 1 Patch Set 1: (3 comments) Patch-set: 1 Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Reviewer: Gerrit User 3678755 <3678755@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 3678755 \u003c3678755@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"} --- 984a8d0a74d76a486698fcf39afa24e3b995b9f2 | 55 ++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 984a8d0a74d76a486698fcf39afa24e3b995b9f2 diff --git a/984a8d0a74d76a486698fcf39afa24e3b995b9f2 b/984a8d0a74d76a486698fcf39afa24e3b995b9f2 new file mode 100644 index 000000000..acc478296 --- /dev/null +++ b/984a8d0a74d76a486698fcf39afa24e3b995b9f2 @@ -0,0 +1,55 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "033fb5b1_7e65c4f7", + "filename": "source/scale_argb.cc", + "patchSetId": 1 + }, + "lineNbr": 701, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-29T23:18:27Z", + "side": 1, + "message": "`ptrdif_t` casts were added to these two lines.", + "revId": "984a8d0a74d76a486698fcf39afa24e3b995b9f2", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": false, + "key": { + "uuid": "34dc66be_5f68f382", + "filename": "source/scale_argb.cc", + "patchSetId": 1 + }, + "lineNbr": 707, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-29T23:18:27Z", + "side": 1, + "message": "In these two lines I moved the `ptrdiff_t` casts to the first operands, so that they look more similar to lines 700-701 above.", + "revId": "984a8d0a74d76a486698fcf39afa24e3b995b9f2", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": false, + "key": { + "uuid": "d3c5f18e_19b1f880", + "filename": "source/scale_argb.cc", + "patchSetId": 1 + }, + "lineNbr": 785, + "author": { + "id": 1001562 + }, + "writtenOn": "2026-07-29T23:18:27Z", + "side": 1, + "message": "Frank: The `clip_width \u003e 32768 || clip_height \u003e 32768` checks were added in https://chromium.googlesource.com/libyuv/libyuv/+/1e4a14f4 on 2015-03-10. But I cannot justify these checks after analyzing the relevant code.\n\nI think the `clip_width \u003e 32768 || clip_height \u003e 32768` checks can be safely removed.", + "revId": "984a8d0a74d76a486698fcf39afa24e3b995b9f2", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + } + ] +} \ No newline at end of file