From 7866d8e08211880f437cfde489271c495375f605 Mon Sep 17 00:00:00 2001 From: "fbarchard@google.com" Date: Mon, 15 Dec 2014 19:51:50 +0000 Subject: [PATCH] Make unittest check every pixel and report the first failure. BUG=269 TESTED=unittest passes on windows R=harryjin@google.com Review URL: https://webrtc-codereview.appspot.com/36509004 git-svn-id: http://libyuv.googlecode.com/svn/trunk@1203 16f28f9a-4ce2-e073-06de-1de4eb20be90 --- unit_test/convert_test.cc | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/unit_test/convert_test.cc b/unit_test/convert_test.cc index fd82ed1aa..ee26015b0 100644 --- a/unit_test/convert_test.cc +++ b/unit_test/convert_test.cc @@ -655,18 +655,14 @@ TEST_F(libyuvTest, FMT_A##To##FMT_PLANAR##N) { \ dst_v_opt, SUBSAMPLE(kWidth, SUBSAMP_X), \ kWidth, NEG kHeight); \ } \ - int max_diff = 0; \ for (int i = 0; i < kHeight; ++i) { \ for (int j = 0; j < kWidth; ++j) { \ int abs_diff = \ abs(static_cast(dst_y_c[i * kWidth + j]) - \ static_cast(dst_y_opt[i * kWidth + j])); \ - if (abs_diff > max_diff) { \ - max_diff = abs_diff; \ - } \ + EXPECT_LE(abs_diff, DIFF); \ } \ } \ - EXPECT_LE(max_diff, DIFF); \ for (int i = 0; i < SUBSAMPLE(kHeight, SUBSAMP_Y); ++i) { \ for (int j = 0; j < SUBSAMPLE(kWidth, SUBSAMP_X); ++j) { \ int abs_diff = \ @@ -674,12 +670,9 @@ TEST_F(libyuvTest, FMT_A##To##FMT_PLANAR##N) { \ SUBSAMPLE(kWidth, SUBSAMP_X) + j]) - \ static_cast(dst_u_opt[i * \ SUBSAMPLE(kWidth, SUBSAMP_X) + j])); \ - if (abs_diff > max_diff) { \ - max_diff = abs_diff; \ - } \ + EXPECT_LE(abs_diff, DIFF); \ } \ } \ - EXPECT_LE(max_diff, DIFF); \ for (int i = 0; i < SUBSAMPLE(kHeight, SUBSAMP_Y); ++i) { \ for (int j = 0; j < SUBSAMPLE(kWidth, SUBSAMP_X); ++j) { \ int abs_diff = \ @@ -687,12 +680,9 @@ TEST_F(libyuvTest, FMT_A##To##FMT_PLANAR##N) { \ SUBSAMPLE(kWidth, SUBSAMP_X) + j]) - \ static_cast(dst_v_opt[i * \ SUBSAMPLE(kWidth, SUBSAMP_X) + j])); \ - if (abs_diff > max_diff) { \ - max_diff = abs_diff; \ - } \ + EXPECT_LE(abs_diff, DIFF); \ } \ } \ - EXPECT_LE(max_diff, DIFF); \ free_aligned_buffer_64(dst_y_c); \ free_aligned_buffer_64(dst_u_c); \ free_aligned_buffer_64(dst_v_c); \