coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-06-18 01:46:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 2

Browse Source 
Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
This commit is contained in:
Gerrit User 1001562 2024-11-06 17:44:49 +00:00 committed by Gerrit Code Review
parent 48603cf6f8
commit 7e6cabe648
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
298bd480ba48b445d8c185b4a660be96256f4b4a
View File

@ -172,6 +172,24 @@
"message": "wtc pointed out that several of these targets have very few files and functions.\n\nAnother option then is to use `__attribute((target_version(\"sve\")))` in the source files on the functions, and not have a separate target with separate flags for these at all.\n\nThis used to not work great on arm, but with https://github.com/llvm/llvm-project/issues/56480 fixed this should be better.\n\nThis would have the advantage that we don\u0027t have to worry about ODR violations from inline functions in headers, too.\n\n(It\u0027d only help if libyuv is one of fairly few targets that do these per-target-feature optimizations. I\u0027d be a bit surprised if that\u0027s true. But if the attributes work, using them would be a nice change regardless of your specific project.)",
"revId": "298bd480ba48b445d8c185b4a660be96256f4b4a",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "f40e6fc1_47a15fa9",
"filename": "BUILD.gn",
"patchSetId": 2
},
"lineNbr": 259,
"author": {
"id": 1001562
},
"writtenOn": "2024-11-06T17:44:49Z",
"side": 1,
"message": "\u003e Another option then is to use `__attribute((target_version(\"sve\")))` in the source files on the functions, and not have a separate target with separate flags for these at all.\n\nDid you mean `__attribute` or `__attribute__`?\n\nThe `target_version` attribute doesn\u0027t seem to be supported by GCC:\nhttps://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html\nhttps://gcc.gnu.org/onlinedocs/gcc/AArch64-Function-Attributes.html\n\n\u003e (It\u0027d only help if libyuv is one of fairly few targets that do these per-target-feature optimizations. I\u0027d be a bit surprised if that\u0027s true. But if the attributes work, using them would be a nice change regardless of your specific project.)\n\nBoth libvpx and libaom also do these per-target-feature optimizations.\n\nhttps://source.chromium.org/chromium/chromium/src/+/main:third_party/libvpx/BUILD.gn;l\u003d354\n\nhttps://source.chromium.org/chromium/chromium/src/+/main:third_party/libaom/BUILD.gn;l\u003d249",
"parentUuid": "5d490a85_1b62ac9a",
"revId": "298bd480ba48b445d8c185b4a660be96256f4b4a",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}