coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-07-31 00:36:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 1

Browse Source 
Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1537962 \u003c1537962@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
This commit is contained in:
Gerrit User 1001562 2026-07-28 08:49:24 -07:00 committed by Gerrit Code Review
parent 31884c9312
commit 8065c009dd
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
9c10ea18c56773ffbe8000b0c996ac3a2cb0eaf1
View File

@ -104,6 +104,24 @@
"revId": "9c10ea18c56773ffbe8000b0c996ac3a2cb0eaf1",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "e0db4d28_bc6c1121",
"filename": "include/libyuv/convert.h",
"patchSetId": 1
},
"lineNbr": 1201,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-28T15:49:24Z",
"side": 1,
"message": "Robert: On second thought, I realized that `ConvertToI420()` is a helper function that dispatches to the appropriate libyuv function based on the `fourcc` parameter. An application can easily create a similar helper function that meets their own requirements. So we don\u0027t need to add an extended version of `ConvertToI420()`.\n\nTo be general, even the assumption that the `src` plane buffers are contiguous in memory should be removed, so the extended version `ConvertToI420()` would need to take an array of `src` plane buffers and an array of `src` strides, plus the size of these two arrays. That seems quite complicated.\n\nIn summary, I am inclined to suggest that you copy and customize `ConvertToI420()` to your application or library to your requirements (you may be able to simplify it), rather than try to extend it to be more general.",
"parentUuid": "80d56f85_7af022fe",
"revId": "9c10ea18c56773ffbe8000b0c996ac3a2cb0eaf1",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {