From 8377c798fb50ba438fb4ec136ea414f33eb0cfcf Mon Sep 17 00:00:00 2001 From: Frank Barchard Date: Thu, 14 Jan 2016 17:38:54 -0800 Subject: [PATCH] Fix I420ToNV21 for wrong dst_stride_y parameter. I420ToNV21 passes the wrong dst_stride_y when it calls I420ToNV12; parameter 8 (convert_from.cc:448) is src_stride_y but should be dst_stride_y. This causes image corruption when converting I420 -> NV21 with mismatched luminance strides. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:547 Review URL: https://codereview.chromium.org/1582793008 . --- README.chromium | 2 +- include/libyuv/version.h | 2 +- source/convert_from.cc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.chromium b/README.chromium index b09a90679..2b5d7cc3e 100644 --- a/README.chromium +++ b/README.chromium @@ -1,6 +1,6 @@ Name: libyuv URL: http://code.google.com/p/libyuv/ -Version: 1565 +Version: 1566 License: BSD License File: LICENSE diff --git a/include/libyuv/version.h b/include/libyuv/version.h index 773a5aebd..39f7ad4af 100644 --- a/include/libyuv/version.h +++ b/include/libyuv/version.h @@ -11,6 +11,6 @@ #ifndef INCLUDE_LIBYUV_VERSION_H_ // NOLINT #define INCLUDE_LIBYUV_VERSION_H_ -#define LIBYUV_VERSION 1565 +#define LIBYUV_VERSION 1566 #endif // INCLUDE_LIBYUV_VERSION_H_ NOLINT diff --git a/source/convert_from.cc b/source/convert_from.cc index 9c138d936..adce52994 100644 --- a/source/convert_from.cc +++ b/source/convert_from.cc @@ -445,7 +445,7 @@ int I420ToNV21(const uint8* src_y, int src_stride_y, return I420ToNV12(src_y, src_stride_y, src_v, src_stride_v, src_u, src_stride_u, - dst_y, src_stride_y, + dst_y, dst_stride_y, dst_vu, dst_stride_vu, width, height); }