coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-06-18 01:46:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 2

Browse Source 
Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
This commit is contained in:
Gerrit User 1115898 2024-10-31 17:36:06 +00:00 committed by Gerrit Code Review
parent 45278ad37e
commit 8ac87c87ab
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
298bd480ba48b445d8c185b4a660be96256f4b4a
View File

@ -33,6 +33,23 @@
"message": "Sorry about the delay in review. I was sick last week and somehow missed this CL.\n\nI am not really qualified to review this change, because I don\u0027t fully understand the problem we need to solve. Here are two initial thoughts.\n\n1) I am not sure if libyuv\u0027s BUILD.gn file can assume the compiler is Clang.\n\n2) I am wondering if it is the [proposed change to build/config/compiler/BUILD.gn](https://chromium-review.googlesource.com/c/chromium/src/+/5904093/1/build/config/compiler/BUILD.gn) that should be changed to use the Clang cc1 flag \"-target-feature\":\n\n\n```\nconfig(\"compiler_arm64_lse\") {\n if (current_cpu \u003d\u003d \"arm64\" \u0026\u0026 aarch64_use_lse) {\n cflags \u003d [ \"-march\u003darmv8-a+lse\" ]\n ldflags \u003d [ \"-march\u003darmv8-a+lse\" ]\n }\n}\n```",
"revId": "298bd480ba48b445d8c185b4a660be96256f4b4a",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "5a7b8249_2245e48a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2024-10-31T17:36:06Z",
"side": 1,
"message": "Does this still work for gcc and other compilers that support -march?",
"revId": "298bd480ba48b445d8c185b4a660be96256f4b4a",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}