From 8faf11d6a845dc0c772d6bfeafee406f32f3109b Mon Sep 17 00:00:00 2001 From: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Mon, 27 Oct 2025 14:12:51 -0700 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"} --- f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7 b/f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7 index 6fca21260..c96be6d55 100644 --- a/f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7 +++ b/f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7 @@ -16,6 +16,23 @@ "message": "f32mm detect for arm. tested on android/chrome emulator", "revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": true, + "key": { + "uuid": "b690f4b0_5b9f9cf5", + "filename": "include/libyuv/cpu_id.h", + "patchSetId": 2 + }, + "lineNbr": 33, + "author": { + "id": 1001562 + }, + "writtenOn": "2025-10-27T21:12:51Z", + "side": 1, + "message": "I found that include/libyuv/cpu_id.h is a public header. For backward compatibility we should not change the values of the constants `kCpuHasSME` and `kCpuHasSME2`.\n\nAre `kCpuHasSME` and `kCpuHasSME2` part of libyuv\u0027s public API? Or are they actually internal constants and just exposed in a public header unintentionally?", + "revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file