diff --git a/0991508bc6c1f7ebe4cc222bc7736c875f59447e b/0991508bc6c1f7ebe4cc222bc7736c875f59447e index 8260aee23..94e61f998 100644 --- a/0991508bc6c1f7ebe4cc222bc7736c875f59447e +++ b/0991508bc6c1f7ebe4cc222bc7736c875f59447e @@ -50,6 +50,24 @@ "message": "My first impression is I dont understand this comment. It refers to a file ane version that arent part of code and ninja builds.\nIf I dont understand it, its likely most contributers wont.\n\nLIBYUV_VERSION is bumped with the API changes, and the calling code may need to check the version before using the API, or an important bug was fixed, and the version helps confirm the fixed version is in use.\n\nIt feels redundent to also have another version, which is not supported by ninja/bazel/code, that gets bumped when the API changes.\n\nThis change/comment refers to a file that isnt necessarily in the repo where a change is made.", "revId": "0991508bc6c1f7ebe4cc222bc7736c875f59447e", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": true, + "key": { + "uuid": "37bcf54a_b3f48e19", + "filename": "include/libyuv/version.h", + "patchSetId": 4 + }, + "lineNbr": 15, + "author": { + "id": 4917106 + }, + "writtenOn": "2026-07-21T12:13:51Z", + "side": 1, + "message": "Perhaps I set the SOVERSION then to YUV_VER_MAJOR.LIBYUV_VERSION.0? Because right now the LIBYUV_VERSION is used a a patch version, which doesn\u0027t reflect the semantic change. I\u0027d even say that using is as a \"major\" would make more sense, because you say it reflects the API breakage.\n\nWhat do you think?", + "parentUuid": "275b16cd_80a123e8", + "revId": "0991508bc6c1f7ebe4cc222bc7736c875f59447e", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file