Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
This commit is contained in:
Gerrit User 1001562 2026-07-27 17:22:09 -07:00 committed by Gerrit Code Review
parent 3429519bd1
commit c27ce2a636

View File

@ -51,6 +51,24 @@
"revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "db033f98_825e75fb",
"filename": "source/scale_common.cc",
"patchSetId": 3
},
"lineNbr": 1632,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-28T00:22:09Z",
"side": 1,
"message": "With the proposed changes, this function uses 32.16 instead of 16.16 and allow a maximum of INT_MAX for `src_height`.",
"parentUuid": "d638e918_eeac63d0",
"revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
@ -67,6 +85,24 @@
"message": "40000 is beyond what 16.16 can index. can we gracefully fail (-1)",
"revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "56ae0f6f_45bfce8b",
"filename": "unit_test/convert_test.cc",
"patchSetId": 3
},
"lineNbr": 2601,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-28T00:22:09Z",
"side": 1,
"message": "The `I210ToI420()` and `I212ToI420()` calls below succeed under both ASAN and UBSAN. Do you think they may still return incorrect results?",
"parentUuid": "84dc2118_4c61a116",
"revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}