coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2025-12-08 01:36:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove stale Android NDK and fix docs [2/2]

Browse Source 
Now that chromium/base has rolled and switched the android_ndk_root to
the new android_toolchain directory, remove the stale Android NDK. Fix
up documentation that refers to stale paths and suggest the appropriate
tools to perform objdump operations.

Bug: 1448383
Test: Verified build of LibYUV.
Change-Id: I7b674052b1ef0914cf4ee81c6c6d62410e5fc569
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/4583622
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Prashanth Swaminathan <prashanthsw@google.com>
This commit is contained in:
Prashanth Swaminathan 2023-06-07 14:11:20 -07:00 committed by libyuv LUCI CQ
parent c1f93246f1
commit d573f6451d
4 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
DEPS
View File

@ -182,10 +182,6 @@ deps = {
'condition': 'checkout_android',
'dep_type': 'cipd',
},
'src/third_party/android_ndk': {
'url': Var('chromium_git') + '/android_ndk.git' + '@' + '310956bd122ec2b96049f8d7398de6b717f3452e',
'condition': 'checkout_android',
},
'src/third_party/android_toolchain': {
'packages': [
{

4
docs/deprecated_builds.md
View File

@ -165,11 +165,11 @@ mipsel
arm32 disassembly:
third_party/android_ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-objdump -d out/Release/obj/source/libyuv.row_neon.o
llvm-objdump -d out/Release/obj/source/libyuv.row_neon.o
arm64 disassembly:
third_party/android_ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-objdump -d out/Release/obj/source/libyuv.row_neon64.o
llvm-objdump -d out/Release/obj/source/libyuv.row_neon64.o
Running tests:

6
docs/getting_started.md
View File

@ -139,11 +139,11 @@ mips
arm disassembly:
third_party/android_ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-objdump -d ./out/Release/obj/libyuv/row_common.o >row_common.txt
llvm-objdump -d ./out/Release/obj/libyuv/row_common.o >row_common.txt
third_party/android_ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-objdump -d ./out/Release/obj/libyuv_neon/row_neon.o >row_neon.txt
llvm-objdump -d ./out/Release/obj/libyuv_neon/row_neon.o >row_neon.txt
third_party/android_ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-objdump -d ./out/Release/obj/libyuv_neon/row_neon64.o >row_neon64.txt
llvm-objdump -d ./out/Release/obj/libyuv_neon/row_neon64.o >row_neon64.txt
Caveat: Disassembly may require optimize_max be disabled in BUILD.gn

2
tools_libyuv/autoroller/roll_deps.py
View File

@ -31,8 +31,6 @@ def FindSrcDirPath():
# Skip these dependencies (list without solution name prefix).
DONT_AUTOROLL_THESE = [
# Disable the roll of 'android_ndk' as it won't appear in chromium DEPS.
'src/third_party/android_ndk',
'src/third_party/gflags/src',
'src/third_party/mockito/src',
]