diff --git a/b119232c3dcd49bc54f76c732ec21d0ed60617bc b/b119232c3dcd49bc54f76c732ec21d0ed60617bc index 7c9b18e02..02a89e17f 100644 --- a/b119232c3dcd49bc54f76c732ec21d0ed60617bc +++ b/b119232c3dcd49bc54f76c732ec21d0ed60617bc @@ -33,6 +33,24 @@ "message": "theres pros and cons to this approach, but the end result is roughly 4x less code, so thats a win.\nIts a little hard to see how the macros piece together into a row function because they are far away from the wrapper. If each macro is basically only used once, it may be easier to understand it if its just above the function?", "revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, + { + "unresolved": false, + "key": { + "uuid": "428cf28e_d73d5563", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 1571352 + }, + "writtenOn": "2024-12-12T11:00:04Z", + "side": 1, + "message": "I\u0027ve moved a couple of macros above their usage, however most of the READ and conversion macros are used in multiple places so I think it makes more sense to keep them together since the register passing conventions between macros is pretty similar.", + "parentUuid": "b26ed1c6_e79a978d", + "revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ] } \ No newline at end of file diff --git a/b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6 b/b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6 new file mode 100644 index 000000000..83792ed22 --- /dev/null +++ b/b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "0225e5cf_82722beb", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 1571352 + }, + "writtenOn": "2024-12-12T11:00:04Z", + "side": 1, + "message": "(rebased)", + "revId": "b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + } + ] +} \ No newline at end of file