From e376b06d6ab8a0b65f690b3b739b49d1cc75ac21 Mon Sep 17 00:00:00 2001 From: Frank Barchard Date: Mon, 20 Jun 2016 10:43:09 -0700 Subject: [PATCH] Disable ScaleFilterCols_SSSE3 which produces color shift upscale a YUV image. observe change in hue.. green especially. disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C observe hue.. green especially, is better. disable HAS_SCALEFILTERCOLS_SSSE3 R=harryjin@google.com BUG=libyuv:605 Review URL: https://codereview.chromium.org/2080663003 . --- README.chromium | 2 +- docs/environment_variables.md | 2 +- include/libyuv/scale_row.h | 3 ++- include/libyuv/version.h | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/README.chromium b/README.chromium index c68487762..ed421217a 100644 --- a/README.chromium +++ b/README.chromium @@ -1,6 +1,6 @@ Name: libyuv URL: http://code.google.com/p/libyuv/ -Version: 1597 +Version: 1598 License: BSD License File: LICENSE diff --git a/docs/environment_variables.md b/docs/environment_variables.md index bc5e2f6fd..5802599e9 100644 --- a/docs/environment_variables.md +++ b/docs/environment_variables.md @@ -22,7 +22,7 @@ By default the cpu is detected and the most advanced form of SIMD is used. But # Test Width/Height/Repeat -The unittests default to a small image (32x18) to run fast. This can be set by environment variable to test a specific resolutions. +The unittests default to a small image (128x72) to run fast. This can be set by environment variable to test a specific resolutions. You can also repeat the test a specified number of iterations, allowing benchmarking and profiling. set LIBYUV_WIDTH=1280 diff --git a/include/libyuv/scale_row.h b/include/libyuv/scale_row.h index df699e6c2..3064ddbdd 100644 --- a/include/libyuv/scale_row.h +++ b/include/libyuv/scale_row.h @@ -61,7 +61,8 @@ extern "C" { #define HAS_SCALEARGBROWDOWN2_SSE2 #define HAS_SCALEARGBROWDOWNEVEN_SSE2 #define HAS_SCALECOLSUP2_SSE2 -#define HAS_SCALEFILTERCOLS_SSSE3 +// TODO(fbarchard): HAS_SCALEFILTERCOLS_SSSE3 doesnt match C very well. +// #define HAS_SCALEFILTERCOLS_SSSE3 #define HAS_SCALEROWDOWN2_SSSE3 #define HAS_SCALEROWDOWN34_SSSE3 #define HAS_SCALEROWDOWN38_SSSE3 diff --git a/include/libyuv/version.h b/include/libyuv/version.h index 3a6bbe3cb..803332185 100644 --- a/include/libyuv/version.h +++ b/include/libyuv/version.h @@ -11,6 +11,6 @@ #ifndef INCLUDE_LIBYUV_VERSION_H_ // NOLINT #define INCLUDE_LIBYUV_VERSION_H_ -#define LIBYUV_VERSION 1597 +#define LIBYUV_VERSION 1598 #endif // INCLUDE_LIBYUV_VERSION_H_ NOLINT