From e6c4b9ad2e791340d5200258ef793f5a00ab7a31 Mon Sep 17 00:00:00 2001 From: George Steed Date: Thu, 18 Apr 2024 15:55:17 +0100 Subject: [PATCH] [Arm][AArch64] Remove unused ARGBToUVJ444Row_NEON definition There is no corresponding declaration in a header file and it appears to be unused, so remove from both the Arm and AArch64. Change-Id: I4de9fb7ce8e8dff6e76f4a99fdd93c743f92bf18 Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/5587507 Reviewed-by: Frank Barchard Commit-Queue: Frank Barchard --- source/row_neon.cc | 19 ------------------- source/row_neon64.cc | 19 ------------------- 2 files changed, 38 deletions(-) diff --git a/source/row_neon.cc b/source/row_neon.cc index 5a1ce50ac..8adbbbb5d 100644 --- a/source/row_neon.cc +++ b/source/row_neon.cc @@ -1885,17 +1885,6 @@ void ARGBToUV444MatrixRow_NEON(const uint8_t* src_argb, static const struct RgbUVConstants kRgb24I601UVConstants = {{112, 74, 38, 0}, {18, 94, 112, 0}}; -// RGB to JPeg coefficients -// UB coeff 0.500 = 127 -// UG coeff -0.33126 = 84 -// UR coeff -0.16874 = 43 -// VB coeff -0.08131 = 20 -// VG coeff -0.41869 = 107 -// VR coeff 0.500 = 127 (ignored) - -static const struct RgbUVConstants kRgb24JPegUVConstants = {{127, 84, 43, 0}, - {20, 107, 127, 0}}; - void ARGBToUV444Row_NEON(const uint8_t* src_argb, uint8_t* dst_u, uint8_t* dst_v, @@ -1904,14 +1893,6 @@ void ARGBToUV444Row_NEON(const uint8_t* src_argb, &kRgb24I601UVConstants); } -void ARGBToUVJ444Row_NEON(const uint8_t* src_argb, - uint8_t* dst_u, - uint8_t* dst_v, - int width) { - ARGBToUV444MatrixRow_NEON(src_argb, dst_u, dst_v, width, - &kRgb24JPegUVConstants); -} - // clang-format off // 16x2 pixels -> 8x1. width is number of argb pixels. e.g. 16. #define RGBTOUV(QB, QG, QR) \ diff --git a/source/row_neon64.cc b/source/row_neon64.cc index feab7502e..06c027fdd 100644 --- a/source/row_neon64.cc +++ b/source/row_neon64.cc @@ -2539,17 +2539,6 @@ void ARGBToUV444MatrixRow_NEON(const uint8_t* src_argb, static const struct RgbUVConstants kRgb24I601UVConstants = {{112, 74, 38, 0}, {18, 94, 112, 0}}; -// RGB to JPeg coefficients -// UB coeff 0.500 = 127 -// UG coeff -0.33126 = 84 -// UR coeff -0.16874 = 43 -// VB coeff -0.08131 = 20 -// VG coeff -0.41869 = 107 -// VR coeff 0.500 = 127 (ignored) - -static const struct RgbUVConstants kRgb24JPegUVConstants = {{127, 84, 43, 0}, - {20, 107, 127, 0}}; - void ARGBToUV444Row_NEON(const uint8_t* src_argb, uint8_t* dst_u, uint8_t* dst_v, @@ -2558,14 +2547,6 @@ void ARGBToUV444Row_NEON(const uint8_t* src_argb, &kRgb24I601UVConstants); } -void ARGBToUVJ444Row_NEON(const uint8_t* src_argb, - uint8_t* dst_u, - uint8_t* dst_v, - int width) { - ARGBToUV444MatrixRow_NEON(src_argb, dst_u, dst_v, width, - &kRgb24JPegUVConstants); -} - #define RGBTOUV_SETUP_REG \ "movi v20.8h, #56, lsl #0 \n" /* UB/VR coefficient (0.875) / 2 */ \ "movi v21.8h, #37, lsl #0 \n" /* UG coefficient (-0.5781) / 2 */ \