coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-02-15 14:50:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add assertions for the Clang static analyzer

Browse Source 
The Clang static analyzer (scan-build) in LLVM 14 warns about
array index out of bounds in scaletbl[boxwidth - minboxwidth] in
ScaleAddCols2_C() and ScaleAddCols2_16_C(). The scaletbl array has two
elements. It's not clear the index boxwidth - minboxwidth is either 0 or
1.

Change-Id: I072476e86950154beffe6b1a89915755118b3cbd
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/4403882
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
This commit is contained in:
Wan-Teh Chang 2023-04-05 14:43:19 -07:00 committed by libyuv LUCI CQ
parent 464c51a035
commit ec48e4328e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/scale.cc
View File

@ -820,6 +820,7 @@ static void ScaleAddCols2_C(int dst_width,
int ix = x >> 16; int ix = x >> 16;
x += dx; x += dx;
boxwidth = MIN1((x >> 16) - ix); boxwidth = MIN1((x >> 16) - ix);
assert(((boxwidth - minboxwidth) == 0) || ((boxwidth - minboxwidth) == 1));
*dst_ptr++ = (uint8_t)(SumPixels(boxwidth, src_ptr + ix) * *dst_ptr++ = (uint8_t)(SumPixels(boxwidth, src_ptr + ix) *
scaletbl[boxwidth - minboxwidth] >> scaletbl[boxwidth - minboxwidth] >>
16); 16);
@ -842,6 +843,7 @@ static void ScaleAddCols2_16_C(int dst_width,
int ix = x >> 16; int ix = x >> 16;
x += dx; x += dx;
boxwidth = MIN1((x >> 16) - ix); boxwidth = MIN1((x >> 16) - ix);
assert(((boxwidth - minboxwidth) == 0) || ((boxwidth - minboxwidth) == 1));
*dst_ptr++ = SumPixels_16(boxwidth, src_ptr + ix) * *dst_ptr++ = SumPixels_16(boxwidth, src_ptr + ix) *
scaletbl[boxwidth - minboxwidth] >> scaletbl[boxwidth - minboxwidth] >>
16; 16;